Identical condition checked twice
Type
Development
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
/src/importexport/internal/ove/ove.cpp line 9428
Code:
if (info.lyricSize_ > 0) {
// lyric
if (info.lyricSize_ > 0) { // <-- identical
if (!readBuffer(placeHolder, info.lyricSize_)) {
return false;
}
info.lyric_ = ove_->getCodecString(placeHolder.fixedSizeBufferToStrByteArray());
}
Comments
in master: src/importexport/internal/ove/ove.cpp, lines 9426- 9433
in 3.x: importexport/ove/ove.cpp, linesL7242-7247
See https://github.com/musescore/MuseScore/pull/7151 (for 3.x)
See https://github.com/musescore/MuseScore/pull/7152 for master
Looks like a day one issue, it is in the code at least since the move to GitHub (412ca45401), so some time between 1.2 and 2.0
Fixed in branch 3.x, commit a757eaf66b
Fix #314687: Identical condition checked twice
Fixed in branch master, commit 4e7d426b6a
Fix #314687: Identical condition checked twice
Automatically closed -- issue fixed for 2 weeks with no activity.