Incorrect alignment of lines at the beginning of a system

• Sep 29, 2014 - 03:16
Type
Functional
Severity
S4 - Minor
Status
closed
Project

These may be a bit prescriptive, but I think they would look better than their current implementation, and would reflect the practice in published sheet music better.

Voltas: If a volta starts at the beginning of the system, its opening hook should be just before the key signature. If it continues into the next system, its continuation should also be just before the key signature.

Pedal segments: If a pedal segment starts at the beginning of the system, it should be just under its first note. If it continues into the next system, its continuation should be just before the key signature.

Version 2.0 on Windows 8.1: voltasegment-1.png

Proposed fix: voltasegment-2png.png

Note that in both cases I had to manually offset the volta line vertically so it would not collide with the clef or key signature - that's a separate issue.

Attachment Size
voltasegment-1.png 85.3 KB
voltasegment-2png.png 85.88 KB

Comments

The second image was produced with modifications to the Line.cpp code, but I would like to hear your comments before submitting a PR.

I don't have any examples at hand to compare with, but it looks good to me.

BTW, a related issue that concerns me more:

If I create a whole note in 4/4 and attach a pedal marking to it, it extends to the end of the measure (I added that code recently). But if you have two half notes, it does not. That's because the position is set to allow pedal changes - the angled hooks - to align. And if you extend one more notch, it aligns to the first note of the next measure. It occurs to me we could check the hook type and differentiate layout based on that - align with start of note note for angled brackets, with end of note (or measure) for straight hook.

CombatCube: are you still thinking of submitting a PR for this? I've got working code for the check on hook type I mentioned above on pedal lines, not sure if I should wait you for or if you are already taking care of this or what.

Pedal segments: If a pedal segment starts at the beginning of the system, it should be just under its first note. If it continues into the next system, its continuation should be just before the key signature.

Actually, if the pedal mark continues on the next system, I think it should start after the key signature, not before:

extract-p106.png

extract-p107.png

Source: Gerou and Lusk, Essential Dictionary of Music Notation, 1996, pp. 106-107

Examples from scores:

burnam.png

Burnam - A Dozen a Day, Book Four (1964)

bartok.png

Bartók - Romanian Folk Dances, Sz.56 (Universal Edition, 1918)

beethoven.png

Beethoven - Piano Sonata No.2, Op.2 No.2 (G. Ricordi & C., 1919)

Attachment Size
extract-p106.png 75.94 KB
extract-p107.png 157.22 KB
bartok.png 137.47 KB
beethoven.png 146.94 KB
burnam.png 74.52 KB

Voltas: If a volta starts at the beginning of the system, its opening hook should be just before the key signature. If it continues into the next system, its continuation should also be just before the key signature.

Similarly, I think that it should be after the key signature. Examples:

schumann.png

Schumann - Album für die Jugend, Op.68 [Muzyka, n.d.(ca.1988)]

beethoven-2.png

Beethoven - Piano Sonata No.13, Op.27 No.1 [C.F. Peters, n.d.(ca.1920)]

schytte.png

Schytte - Melodische Vortragsstudien in allen Tonarten, Op.159 (Wilhelm Hansen, 1909)

Attachment Size
beethoven-2.png 86.19 KB
schumann.png 29.56 KB
schytte.png 60.05 KB

BTW, here is a link to the forum discussion that led to this issue being filed:

http://musescore.org/en/node/34886

Heads up: I am planning to fix some of these continuation issues as part of my PR for pedal. At least pedal continuation, and whatever other lines would benefit from the same change. I'll let you know what I end up doing.

Status (old) active patch (ready to commit)

https://github.com/musescore/MuseScore/pull/1352

This includes my adjustment to pedal length as well as startpoint for continuation lines. Because the fix for pedal continuation ended up being the same fix needed for other lines such as hairpins and voltas, I went ahead and implemented it for them as well. All continuation lines for segment- and measure- anchored lines would now start right after the clef/keysig/timesig. And I change the regular startpoint for voltas as well.

Here are the vtests for my proposed fix:

line-2-ref.png

line-3-ref.png

Attachment Size
line-2-ref.png 9.36 KB
line-3-ref.png 9.25 KB