Palette takes keyboard focus when undocked

• Jan 24, 2015 - 23:11
S4 - Minor

Ubuntu 14.04, GIT commit: 8c2401f

1) start MuseScore
2) undock Palette
3) click a rest in My First Score
4) double click fermata in Articulation palette
5) try the cursor keys, home, end, page up, page down, etc

Result: focus is on the Palette window, not the score. Page Up/Down are especially bothersome as they operate the worksapce control at the bottom of the palette.

Everything works as expected for me when the palette is docked.


There is similar behavior for the Inspector, although it is less clear - apparently F8 won't toggle the window if the Inspector starts off undocked. See thread referenced above.

I've fixed the problem with the palette, I can make a pull request just for it if you want.
The focus grabbing in inspector will take a bit longer, but I can't seem to be able to reproduce the problem with F8.

Andrei: FWIW, I vote you do PR's separately - that way they get tested right away. And if it becomes necesasry to revert one later, it's easier.

By "focus grabbing in Inspector", do you mean, enabling "Esc" (or some other key if necessary) to return focus to the score once you've moved focus to the Inspector? My sense is, this is the next most important priority.

The F8 toggling issue I can't reproduce either, but it seems less important anyhow. Miwarre, we could use detailed instructions, probably would have to be starting from a fresh startup with the "-F" option to revert to factory settings. But I think there are other accessibility issues more important - like if we can get the menu mnemonics A-G working :-)

@Miwarre: Thank you for the informations! :)
@Marc: I had to fix the escape problem for the PR with accessibility for Play Panel, Synthesizer and Mixer as well. I don't know if it was the changes in code, or moving from Qt 5.3 to 5.4, or from Windows 7 to 8.1, but things didn't work as well as they did back when I first made the PR. I will finish the rebase for that most likely on Friday after my exam. I want to double check it for any additional problems.

Status (old) patch (code needs review) fixed

This should be fixed in the latest sources. If not, please reopen it. The problem with F8 toggle might still be the case, but it should have a different issue report, same for the Master Palette.
From now on, if the focus somehow goes into the palette or inspector, pressing Escape should take you in the score *without* changing the selection.

I'm glad! :) Miwarre , in the future please don't hold back on reports. Focus management is not very easy to maintain with MuseScore having a huge amount of widgets that can steel focus in a way that I may have not tested, so I'm also relying on these reports. Moreover, new widgets are constantly added (for example when I did the focus management the first time, the palette did not have workspaces, so the combobox is a new addition and it was the one stealing focus). Marc is very kind to let me know when a bug is reported so I can quickly fix it.