Tuplet bracket too high for unbeamed eighths
Ubuntu 14.04, GIT commit: 0dfcac4
1) new score, 4/4
2) note entry mode
3) 6, Ctrl+5, 0 B 0 A 0
Result: tuplet bracket is way too far above staff
I can reproduce similar cases many other ways. Investigating the cause for this, it appears the chord bboxes are sometimes way off, and this is fooling the code that detects collisions within the tuplet. In this case, it seems to be the B whose bbox is entirely too tall (and also shifted to the right?). I have unfortunately noticed bad chord bboxes before and either worked around it or lived with it, on the basis of the principle that only elements that are actually drawn should be expected to have reasonable bboxes.
But there are places in the code where we either do or should/code rely on chord bboxes, and this appears to be an especially bad consequence of them not being good. I looked at the code that calculates the chord bbox at the bottom of Chord::layoutPitched() using processSiblings(), but I don't know what the problem is - whether one of the siblings is bad or the method of accumulating the results is or what.
Meanwhile, I can again work around this by changing the collision detection code to use upNote() or downNote() bbox instead of the chord bbox. But at some point, we should consider looking at the chord bbox code.
Comments
https://github.com/musescore/MuseScore/pull/1716
This fixes the problem at hand (tuplet height calculation) by replacing the chord bbox in the collision calculations with upNote or downNote. I did not attempt to fix the chord bbox calculation.
Fixed along with #33911: tuplet brackets for beamed tuplets don't follow the beam's slope
Automatically closed -- issue fixed for 2 weeks with no activity.
Automatically closed -- issue fixed for 2 weeks with no activity.
Automatically closed -- issue fixed for 2 weeks with no activity.
Automatically closed -- issue fixed for 2 weeks with no activity.
Automatically closed -- issue fixed for 2 weeks with no activity.
Automatically closed -- issue fixed for 2 weeks with no activity.
Automatically closed -- issue fixed for 2 weeks with no activity.