Adding notes deletes contents of unrelated staff if linked staves present

• Mar 17, 2015 - 03:40
Type
Functional
Severity
S2 - Critical
Status
closed
Project
MuseScore

Ubuntu 14.04, GIT commit: f953fe7

1) new score, flute + guitar, add linked staff to guitar staff
2) add note to flute staff

Result: the measure rest is deleted from the top guitar staff

Similarly, adding note to top guitar staff removes the measure rest from the flute staff

Somewhere we must be off by one with a staff index?

Comments

• Mar 17, 2015 - 03:58

Somehow, the initial rests for all three staves are linked together. It's always one staff above the two staves that gets mixed up in this. Even you have additional staves above the flute, it's still only the flute that has issues with the guitar.

Looks like this was broken at the RC, but was working last month.

Reply

• Mar 17, 2015 - 04:35

This appears to be a result of the re-architecting of new score creation a few weeks ago. The problem is here:

https://github.com/musescore/MuseScore/blob/master/mscore/file.cpp#L643

If I understand correctly, the idea is to link the rests we insert for linked staves, which makes sense. But the problem is, when we get to the first linked staff, rest is non-null from the previous staff, so we link that too.

Solution would seem to be simple - set "rest" back to null at the end of the loop for non-linked staves, so their rests don't get re-used. I see there was some back and forth regarding this very section code, so I'll look to see if there isn't something else that makes more sense. But so far, just adding that seems to fix it.

Reply

• Mar 17, 2015 - 04:46

This issue appears likely on March 3

I receive this correct result on this Nightly on March 1 (the last one of this day I think, no nightly on March2) : 1d90b26

With result:
result March1.jpg

I get a fail with this one: 19e8f45

Result:
result March3.jpg

After checking, the second mentionned Nigthly doesn't seem involved?
Furthermore, I see two commits (except oblivion of my part) between this two nightlies. And I don't understand for the moment where might be the problem with those ?

- https://github.com/musescore/MuseScore/pull/1831
- https://github.com/musescore/MuseScore/pull/1833

Or? - https://github.com/musescore/MuseScore/commit/0f688a47ffc1ec4032a3f1aca…

EDIT: I had sent my message before to verify in the thread the previous message of Marc :(

Reply

• Mar 17, 2015 - 04:51

I think the problem is, there were actually a whole bunch of commits made in a short period of time relating to the change to how scores are created, and probably no nightlies were available for some of them.

The same problem exists for pickup measures, btw, even if I make the change I proposed above. I think I need to add similar code elsewhere. Still investigating.

Reply

• Mar 17, 2015 - 05:22
Status (old) active ⇒ patch (code needs review)

https://github.com/musescore/MuseScore/pull/1892

Works for both regular and pickup measures (tested with 3/8) in my tests. Looks from the code like there is allowance for the possibility that different staves might have different numbers of rest, but I have no idea how to generate that condition, so I can't say for sure what would happen.

Reply