Ornament sound events: wrong articulation

• Nov 4, 2015 - 22:06
Reported version
2.1
Type
Functional
Severity
S4 - Minor
Status
PR created
Project

Context any stable or unstable version since at least 2.0.1

Description:

When the sound events for a note with an ornament are created, the required separation from the following event (articulation: either the default instrument articulation or the one depending on articulation signs) is applied to each event making the note up, rather than to the note as whole.

As a result:

1) each ornament sound event is played non-legato

2) the note as a whole receives an articulation which depends on the duration of its last event rather than on its entire duration.

Example:
test_ornam_timegate_1.png

Here, the note with the trill is selcted and the default instrument articulation is in effect (95%). As it is shown by the piano roll:

1) each event making the trill up is shortened by its 95% (while ornaments are played legato in the great great majority of cases) and

2) the note as a whole is shortened by the 95% of its last event and not by the 95% of its total duration, as it should.
_______________

By contrast, a more correct general articulation could be (screen shot coming from a fix I am working on):
test_ornam_timegate_2.png

where the ornament (sub-)events are legato and the whole note is shortened by its 95%.


Comments

Another example, this time with a staccato note.

Current implementation:
NOT FOUND: 1
Note the staccato (half-length) ornament events and the main note which is longer than it should be for a staccato note (as it covers half of the remaining time rather than stopping at half of the total duration).

        VERSUS

Fixed implementation:
NOT FOUND: 2
Note the legato ornament events and the main note which stops at half of the total duration, for a global staccato effect.