Disappearing dots

• Nov 29, 2015 - 04:55
Reported version
2.2
Type
Graphical (UI)
Severity
3
Status
closed
Project

When playing a score, the dots on a dotted eighth rest disappears.

GIT commit: f51dc11


Comments

Severity
Status (old) needs info active
Status needs info active
Reported version 2.2

I reproduced this issue. As the playback cursor passes over a dotted eighth-note rest, the dot is fully or partially erased. Pausing causes all dots to reappear.

In my full score, the glitch occurs in Continuous and Page layout. In this sample score, it only occurs on the second measure, in Continuous layout.

OS: OS X 10.13, Arch.: x86_64, MuseScore version (64-bit): 2.2.1, revision: 51b8386

I cannot get the dots to disappear from notes. This is probably because NoteDot is an element that can draw itself independent from the Note to which it belongs. But NoteDots cannot belong to Rests, and a Rest's bbox is only as wide as its symbol (without the augmentation dots). Therefore, when the ScoreView is given an area to draw that includes a Rest's augmentation dot, but no other part of the Rest, the dot will be erased until the Rest is drawn again. This can be solved by making the Rest's bbox wide enough to include its augmentation dots.

Hi Mike,
I am still unable to observe this problem with dots after notes, no matter how many dots are after the note. Can you please show me a score where you see this problem, and point out where to look?

My patch fixes this issue by widening the Rest's bbox to include all of its augmentation dots. Another way to solve this problem would be to extend (and possibly rename) NoteDot to be able to apply to Rests as well as Notes. I might actually prefer that solution. It may be that NoteDot solves certain problems that dotted rests do not have, but if each dot after a Note can be adjusted by the user, it stands to reason that a user should expect to be able to individually select (and adjust) each dot after a Rest.

I'm not crazy about the idea of changing the rest bbox as this could have unforeseen effects on layout. Unless we decide it's actually correct. But it's all being re-worked for 3.0 anyhow. I do in principle prefer using the same mechanism for dots on rests as dots on notes, and in fact never realized we didn't already!

Severity
Status (old) patch (code needs review) fixed
Status fixed

Fixed in branch master, commit daa4802f33

fix #89016: Disappearing dots
Use NoteDot for the dots after rests, instead of the rest drawing its own dots, which were drawn outside of the rest's bbox.