Add single-staff marimba to Instruments.xml

• May 16, 2016 - 20:11
Reported version
3.0
Type
Functional
Severity
S5 - Suggestion
Status
closed
Project

The marimbas in the standard instruments.xml are a grand staff marimba and a single-staff bass marimba. However, a single-staff marimba line is what is usually used for ensemble literature, rather than a grand staff (which is more common in solo literature). We should have a second marimba option in instruments.xml for "Marimba (single-staff)" and rename the current marimba entry to "Marimba (grand staff)".


Comments

That's the workflow I've been using.

In my experience, there have been many more people who use a single-staff marimba part much more frequently than the grand staff, so it would save them clicks to have a single-staff option.

Status (old) active patch (code needs review)
Reported version 2.1 3.0

I made some tweaks to Instruments.xml that address issue #111331, and I added a single-staff option for the marimba as well. Let me know if I should re-arrange which genres the instruments go in.

If this looks good, I'll go submit a pull request on GitHub.

Attachment Size
instruments.xml 430.76 KB

Make it "Grand Staff" and "Single Staff" in the tracknames, and add the corresponding lines to instrumentsxml.h. See attached.
I'd have a PR ready, just let me know whether you prefer to do it yourself

Attachment Size
instruments.zip 31.79 KB

It looks like we tried to do this at the same time. That would explain why I had some conflicted files. I'll cancel my PR, since yours hit first.

Status (old) patch (code needs review) fixed

Fixed in branch master, commit 39ed0ec470

fix #111431 and fix #111311: some additions/corrections to instruments.xml

* Add single-staff marimba and contrabass marimba to instruments.xml
* Fix come incorrect pitched percussion instruments' default ranges
in instruments.xml
* Fix Traverso short name (ommision from 10bca19f)
* Add channels to Harp for staccato and flageoletti, see #18779 and
https://musescore.org/de/node/110481#comment-499521 ff.
* Fix apparent typos for octave-mandolin and contrabasses

Fixed in branch 2.0.4, commit 4f73232694

fix #111431 and fix #111311: some additions/corrections to instruments.xml

* Add single-staff marimba and contrabass marimba to instruments.xml
* Fix come incorrect pitched percussion instruments' default ranges
in instruments.xml
* Fix Traverso short name (ommision from 10bca19f)
* Add channels to Harp for staccato and flageoletti, see #18779 and
https://musescore.org/de/node/110481#comment-499521 ff.
* Fix apparent typos for octave-mandolin and contrabasses