Expression text badly placed by default, placement not saved

• Nov 29, 2018 - 17:24
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project

Expression text (added via Ctrl+E or from palette via drag/drop or by double-click) gets placed too close to the staff - basically touching it. Press X to flip it above, then again to flip it below, and now it positions how I might expect - same as staff text flipped below.

I guess what is happening is, the expression text is created as staff text with Tid::EXPRESSION and then explicitly set to Placement::BELOW, but it's taking the default offset from EXPRESSION text style, which is 0. I think probably the easy fix is to just pick a more reasonable default offset for the text style - probably the same 3.5sp used for staff text, since that's where it ends up anyhow after two flips. But it's worth considering if we want to make expression text a more "first class" citizen, rather than just a special text style for staff text.


Comments

Title Expression text badly placed by default Expression text badly placed by default, placement not saved
Priority P2 - Medium P0 - Critical

Also, the placement below is lost on save/reload, which is why I'm marking this critical. Actually, the placement of expression text varies according to whether added by shortcut or from the main palette or from the master palette. About to submit a PR that fixes all of this.

Fix version
3.0.1