Too much space allocated around tab staff with"beamed" notes
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.0.0.4725, revision: d32f837
Open the attached file (created in 2.x) and take the reset. Select the accent in measure 6 and decrease the Y-offset.
Expected result: The position of the previous system should have priority and block the progress of the dynamic.
Actual result: The element continues to push the previous system upwards.
Attachment | Size |
---|---|
chansonette_2.x.mscz | 32.94 KB |
Fix version
3.0.3
Comments
That's not how it works - if you ask for a symbol to be a certain height above the staff, MuseScore does what you ask. It also tries to avoid collision with the staff above. If you want to avoid the collision, turn off autoplace.
But there is a bug here, and that is that we start increasing system distance before the accent actually hits the staff above. Apparently we allocate a border around tab staves that we don't around standard - change the bottom staff to standard in Edit / Instruments and you'll see you're allowed to raise the accent all the way up until it almost touches the staff.
The cause appears to be that we are erroneously including the non-existent beam in the skyline. This is an issue only for beamed notes - in a debug version of MuseScore 3, this is clear as day if you enable Debug / Show Skylines:
This bug also affect staff/tab spacing and should be fixed at the same time: #281127: Grand staff distance excludes tablature and organ pedal staff.
As noted in the comment there though, the bugs are completely unrelated so no particular reason from an implementation standpoint they need to be considered together. PR's for them can and should stand alone.
In my investigation, it seems this is only a problem for scores imported from 2.x using a custom tablature style and not then saved in MuseScore 3. Or, immediately after a change to "simple" style within MuseScore 3, but again, it goes away on save / reload. So, not a problem for 2.x scores that use a predefined tab style, and not a problem for MsueScore 3 scores except after a change in style, and not a problem for any score after save/reload. That's because the problem only happens if the beam is first created and then a change makes it go away.
Assuming my findings are correct, it's a more minor bug than it may have appeared at first, but nevertheless, here's a fix:
https://github.com/musescore/MuseScore/pull/4712
Fixed in branch master, commit bda0dd2345
fix #280428: tab beams added to skyline
Fixed in branch master, commit b459deb257
_Merge pull request #4712 from MarcSabatella/280428-tab-beam
fix #280428: tab beams added to skyline_
Fixed in branch 3.0.x, commit 519d1152bc
_Merge pull request #4712 from MarcSabatella/280428-tab-beam
fix #280428: tab beams added to skyline_
Automatically closed -- issue fixed for 2 weeks with no activity.