Crash on undoing removal horizontal frame

• Feb 5, 2019 - 18:07
Reported version
3.0
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
MuseScore

3.0.2 / Windows7

1) SATB template (test file: pages view and continuous horizontal frame.mscz )
2) Insert an horizontal frame
3) Generate parts
4) In main score (in Page View or Continuous View): cut the horizontal frame

Just for checking, toggle in parts: note the horizontal frames have not been deleted as expected

5) Undo (in part or main score)

Result: crash

Comments

• Mar 9, 2019 - 09:49

This crash is reproducible for me in current master even without generating parts and in Treble clef template. Maybe it is something separate though.

Reply

• Mar 9, 2019 - 19:08
Title Crash on undoing removal horizontal frame in score with parts ⇒ Crash on undoing removal horizontal frame

I observe the change/crash on June 11, 2018

Edit: also this one about undo/redo (but related to text, so less likely?) between the two mentioned commits: https://github.com/musescore/MuseScore/commit/bfdc71d71058d76170f015523…

Reply

• Mar 9, 2019 - 21:49
Status active ⇒ PR created

Thanks cadiz1, that is indeed a helpful information! The commit you pointed is indeed related to the crash, and it actually does the right thing and fixes the bigger problem with undoing boxes removal, which is what #269919: Crash (access negative array index assert failure) when delete titlebox, change initial chordrest duration, and undo twice is about.

After fixing the crash I also checked the behavior of this scenario with parts, and found that frames removal is indeed not synchronized between parts — but only if they were generated before the moment those frames were added. Those frames created before parts generation seem to be removed correctly.

If this all is correct, here is a PR to fix these issues: https://github.com/musescore/MuseScore/pull/4786.

Reply

Fix version
3.1.0