Crash on undoing removal horizontal frame
Reported version
3.0
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
3.0.2 / Windows7
1) SATB template (test file: pages view and continuous horizontal frame.mscz )
2) Insert an horizontal frame
3) Generate parts
4) In main score (in Page View or Continuous View): cut the horizontal frame
Just for checking, toggle in parts: note the horizontal frames have not been deleted as expected
5) Undo (in part or main score)
Result: crash
Fix version
3.1.0
Comments
This crash is reproducible for me in current master even without generating parts and in Treble clef template. Maybe it is something separate though.
Indeed, confirmed with 2c21b2a
(on Insert or Append Horizontal frame -> Cut -> Undo)
I observe the change/crash on June 11, 2018
No problem on Undo and the horizontal frame with :
c6ccd63
But crash with the first commit/nigthly (related to Undo/Redo operations, so ?) : fa65de8
To fix: #269919: Crash (access negative array index assert failure) when delete titlebox, change initial chordrest duration, and undo twice
No matter if there is parts or not: same result
Edit: also this one about undo/redo (but related to text, so less likely?) between the two mentioned commits: https://github.com/musescore/MuseScore/commit/bfdc71d71058d76170f015523…
Thanks cadiz1, that is indeed a helpful information! The commit you pointed is indeed related to the crash, and it actually does the right thing and fixes the bigger problem with undoing boxes removal, which is what #269919: Crash (access negative array index assert failure) when delete titlebox, change initial chordrest duration, and undo twice is about.
After fixing the crash I also checked the behavior of this scenario with parts, and found that frames removal is indeed not synchronized between parts — but only if they were generated before the moment those frames were added. Those frames created before parts generation seem to be removed correctly.
If this all is correct, here is a PR to fix these issues: https://github.com/musescore/MuseScore/pull/4786.
Fixed in branch master, commit 90940d634a
fix #283545: fix a crash on undoing HBox removal, fix boxes linking in parts
Fixed in branch master, commit bce3db5923
_Merge pull request #4786 from dmitrio95/283545-hbox-remove-undo
fix #283545: fix a crash on undoing HBox removal, fix boxes linking in parts_
Automatically closed -- issue fixed for 2 weeks with no activity.