Fretboard diagrams: Barré property is redundant
Reported version
3.0
Type
Functional
Frequency
Once
Severity
S5 - Suggestion
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.0.3.5341, revision: e06ea8e
It's not clear why "Barré" was added to the Inspector for Fretboard diagrams. It adds no extra function or convenience to the UI, and has the same bugs as the already established Shift + click method of adding barrés. IMV, it should be removed.
Related to #283681: [EPIC] Fretboard diagram issues.
Fix version
3.1.0
Comments
https://github.com/musescore/MuseScore/pull/4785
The argument I can see to leave it is that it is directly visible to a user. While testing the fretboard diagrams now (I didn't use them before) I could instantly see the ability to set up a barre (although it behaves slightly unintuitive sometimes) while I didn't know anything about Shift+click until I read this issue description. If removing this property, should we perhaps add some more user-visible action for adding a barre (perhaps a right-click menu or even just a label "Use Shift+click to add a barre" at the bottom of fretboard editor)?
The new fretboard implementation in my PR removes the barre property, but also adds a barre button that allows a user to add a barre a bit more explicitly than just with shift click. I have left the shift click functionality in, and hovering over the barre button shows a tool tip with the keyboard shortcut mentioned. I think that should be enough. Thoughts?
Ah, then it should indeed be OK, I'll test the new editor.
Fixed in branch master, commit 40cef95299
_Refactor fret diagrams
fix #284966
fix #283759
fix #283678
fix #283676
fix #283674
fix #283452
fix #275658
fix #265324
fix #285616
fix #285613
fix #280575
fix #283762
fix #283679_
Automatically closed -- issue fixed for 2 weeks with no activity.