Wrong default position of Chord Symbols attached to fret diagrams

• Jun 7, 2020 - 09:39
Reported version
3.x-dev
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project
MuseScore

I guess it's a side effect of this fix ? : #304057: Chord Symbol offset keeps resetting to zero
Now, chord symbols attached to fret diagrams display a wrong Y offset (-2,50, well it's the default of chord symbols, but without fret diagrams!)

Steps:
1) Default score in 86614bb
2) Add the C fret diagram

Result: chord symbol is completely misplaced regarding the diagram (Y offset, and probably X offset, not really centered)

accord de Do.jpg

Comments

• Jun 7, 2020 - 13:37

Indeed, after checking, this one "works" (3419430): initial display of chord symbol + fret diagram is correct. But custom offsets are lost after Save.
With the next one, as mentioned above, it's the reverse: initial display is wrong, custom offsets are preserved.

Reply

• Jun 7, 2020 - 19:36
Status PR created ⇒ fixed

Fixed in branch 3.x, commit 158b643a1a

_fix #306438: wrong default offset for chord symbols on fret diagrams

Resolves: https://musescore.org/en/node/306438

The issue was introduced with a fix for
https://musescore.org/en/node/304057,
but the fix was too broad: it eliminated all reset of offset
for harmony objects on fret diagrams.
The original problem was we always reset it,
the fix was to never reset it.
The right answer is to reset it if styled.
Then manual adjustments are preserved,
but if no manual adjustments are present,
we reset it - which is to say, set is to the style default._

Reply

Fix version
3.5.0