Allow new templates to be seen without restart
Reported version
3.0
Priority
P2 - Medium
Type
Functional
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
Right now if you create a new template (save to Templates folder) it doesn't reflect in the New Score Wizard until restart. That's because we populate the list on startup, or at least the first time you open it, and then never update it.
I recognize that keeping the same instance of the wizard active is what allows us to remember settings from one invocation to the next and that's good, but it shouldn't be hard to factor out the code that handles the template list and calling it on every invocation.
Comments
see https://github.com/musescore/MuseScore/pull/3522
Can this one still make it into 2.2?
Didn't make it in 2.2, most probably won't make it into 2.3, may make it into 3.0...
Just for experiment I created a PR for 2.3: https://github.com/musescore/MuseScore/pull/3771
Much simpler way in https://github.com/musescore/MuseScore/pull/3773
Fixed in branch 2.3, commit 2ffcf35630
Fix #269952: show new templates in new score wizard w/o restart
Fixed in branch 2.3, commit f6b55d79f0
Merge pull request #3773 from Jojo-Schmitz/templates-2.3
Fix #269952: show new templates in new score wizard w/o restart
Reopen for master
Actually the 2.3 fix should apply to master too, once the extension stuff went in
Will this get merged soon? I fear bitrot. :-P
It is in 2.3 already and in master some prerequisite was missing. I believe that is in meanwhile, but can't check right now
Yep, but not in master.
PR https://github.com/musescore/MuseScore/pull/3522 got rejected
Won't the changes from https://github.com/musescore/MuseScore/pull/3773 still work for master?
Can we please merge this for 3.0?
Like by doing a
git cherry-pick 2ffcf35(and resolving the merge conflict)Done in https://github.com/musescore/MuseScore/pull/4110
oops, apparently not that simple, there isn't an
updateNewWizard()in master?!?and
NewWizard::updateValues()is declared but not defined.Now it is...
Fixed in branch master, commit ed3aa5ae5a
Fix #269952: show new templates in new score wizard w/o restart
Fixed in branch master, commit 1b10c214e9
Merge pull request #4110 from Jojo-Schmitz/template-reload
Fix #269952: show new templates in new score wizard w/o restart
Automatically closed -- issue fixed for 2 weeks with no activity.