[MusicXML] Layout exports despite being disabled in Preferences

Which option did you you check in preferences?

Bug reproduces on reasonably current trunk. The "export layout" switch is simply ignored (preferences.musicxmlExportLayout is missing from the if statement that determines if breaks must be exported). To be fixed.

I found this bug is easy to fix. But I'm new to MuseScore development, so I want to double check here.
In exportxml.cpp, when we don't need layout, we should not print anything about the "print" tag. In line 4722, however, it still output "print" tag.
May I start a pull request for this issue?

Just go ahead and have a try at it ;-)

Welcome to MuseScore development ! All help is welcome, especially pull requests.

Before you start, I'd like to make a few remarks. This "bug" was reported long ago and while initially I agreed, as of today I feel slightly differently.

I do agree the current behaviour may be counter-intuitive: the preferences dialog does not allow you to change the "export breaks" setting when "export layout" is disabled. The export code, though, always complies with "export breaks" even when "export layout" is disabled. Apparently some users expect no breaks when "export layout" is off, while actually the export acts according to the break setting (which is disabled in the dialog).

Furthermore, in retrospect I think exporting layout makes no sense without also exporting all breaks, while without other layout info (element positions) exporting the breaks may still make sense.

Thus according to my current opinion, the valid choices would be
- no layout (no positions, no breaks)
- manual breaks only (no positions)
- all breaks only (no positions)
- full layout (all breaks and positions)
This would also require changing the preference dialog.

I will further work on this. Currently I cannot distinguish manual breaks and system breaks.

I have fixed this. In Preferences - Export - MusicXML, there are four options, one for one option in your four valid choices. Here are the files exported and UI in my version.

https://github.com/musescore/MuseScore/pull/4368

Since I am not familiar with github pull requests, I deleted the old repo and the old PR cannot be updated. I have opened a new PR:
https://github.com/musescore/MuseScore/pull/4443

Thank's a lot! This is really helpful.

See https://github.com/musescore/MuseScore/pull/5471

relates to #270643: [EPIC] MusicXML import/export issues

Fixed in branch master, commit 1b10b9083a

fix #23187 - [MusicXML] Layout exports despite being disabled in Preferences (based on KuribohG's changes)

Fixed in branch master, commit 3a5c4ad62b

_Merge pull request #5471 from lvinken/23187-musicxml-export-layout-gui

fix #23187 - [MusicXML] Layout exports despite being disabled in Preferences_

Automatically closed -- issue fixed for 2 weeks with no activity.