Elements in Toolbar Editor are not translatable

• Apr 17, 2019 - 10:47
Reported version
3.0
Type
Wording/Translation
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
MuseScore

In 3.1 beta OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.1.0.6437, revision: 06f0ddd
And 3.1 Nightly OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.1.0.6501, revision: b9a410d

After created an customized Workspace.
Open the Toollbar Editor in "View > Toolbars > Customize Toolbars..."
Elements in the dialog box are not translatable.

Toolbar Editor.png

Is it possible to add their strings in Transifex ?

Comments

• Apr 17, 2019 - 14:49
Status active ⇒ PR created

Should be partly fixed (the left-most part of that dialog) with https://github.com/musescore/MuseScore/pull/4934
It seems not to be (easily) possible to make the 2 other parts translatable
Or maybe it is, but those strings would need to get improved for their readability.
Maybe we should not show those strings at all (dunno how though?), but just the icons.
That again would leaves the 4 voice entries to need icons...

Reply

• Apr 17, 2019 - 18:21

Thanks for this PR, a very good beginning.
For the icon strings, we already have something, could it be possible to reuse them ?
For example, the "Count-In" button in "shortcut.cpp" line 2928 :
MsWidget::MAIN_WINDOW,
STATE_NORMAL | STATE_NOTE_ENTRY | STATE_PLAY | STATE_EDIT,
"countin",
QT_TRANSLATE_NOOP("action","Count-In"),
QT_TRANSLATE_NOOP("action","Toggle 'Count-In' playback"),
QT_TRANSLATE_NOOP("action","Play count-in at playback start"),
Icons::countin_ICON,
Qt::WindowShortcut,
ShortcutFlags::A_CHECKABLE

Reply

• Apr 17, 2019 - 18:30

Possible, but these are not the strings taken here, it takes the ones from mscore/musescore.cpp, line 208 ff
Those strings in turn are not designed to show in a UI, but for saving them in a custom workspace file, where they should not end up translated. So I believe the best option here would to not show them at all, just the icons. I'm just not sure (euphemism for: I don't have the slightest idea) how to do this.

Reply

• Apr 18, 2019 - 09:48
Status PR created ⇒ fixed

Fixed in branch master, commit 36c9902104

_partial fix #287858: make elements in Toolbar Editor translatable

for now just the toolbar names, not (yet?) their elements.
But also some string improvements_

Reply

Fix version
3.6.0