Reduce ambiguity in marching snare drum notation

• Jun 3, 2016 - 05:07
S5 - Suggestion

I'm also switching the key to press for "snare hit" and "buzz", since "B" isn't as easy of a key to hit as "A", and you use "snare hit" far more often than "buzz" (and buzz starts with "B").

See also: #113656: Reduce ambiguity in marching cymbal notation, #113646: Improve keyboard assignment for marching tenors, and #113651: Improve keyboard assignment for marching basses (all spawned from Re-assign notes for keyboard entry of marching percussion parts? and will be handled in the same PR)


I don't really have anything to contribute, except say "keep up the good work." Just a note about the git workflow—whether you use multiple commits or one, you should include "fix #00000" in the commit message(s). If it's one commit, just put them one after another: "fix #113816, fix #113656, fix #113646, fix #113651: Various marching percussion improvements" (or something like that).

Status (old) active patch (code needs review)

I've made commit 77bdc12 with my proposed changes. I've got a couple of questions about issues #109826: Add 2nd spock drum to Marching Percussion Tenor instrument and clean up amplitude envelopes, #114186: Add stick clicks to Marching Tenor instrument, and #114181: Add simultaneous hit to Marching Bassdrum instrument I'd like answered before I send it in for a real PR.

Let me know what you think of the key assignments and if you find that my improved notation is, in fact, an improvement.

I rebased the commit so that it works nicely with the nightly. I will need to make another commit to update the templates where these instruments are used once this PR is accepted.

Status PR created active
Reported version 2.2  
Regression No
Workaround No

The pull request has been archived.