Make sure that the PulseAudio QGroupBox covers at least the bottom edge of the PulseAudio checkbox with consistent margin. Purely cosmetic fix, so doesn't look unprofessional.
Make sure that the PulseAudio QGroupBox covers at least the bottom edge of the PulseAudio checkbox with consistent margin. Purely cosmetic fix, so doesn't look unprofessional.
Comments
I should say I'm was on a new arch system which doesn't have pulseaudio installed.
After switching to alsa and restarting musescore, I still see that PulseAudio QBox is a little too small:
MuseScore 2.0.3 also has this QGroupBox (sorry not a "QBox") too small. Here is what 2.0.3 appimage looks on arch linux mate:
That looks the same for 2.0.3 arch linux's build, as well as when on lxde.
Seems if I set minimum height of that PulseAudio QGroupBox to 30 then looks ok:
Now I'm wondering if that will screw up something else, for instance if build with PULSE_AUDIO OFF...
ok, just to verify that I didn't mess up what this preferences gui looks like with PULSE_AUDIO OFF in CMakeLists, I recompiled and got:
which is the desired output (the pulse audio QGroupBox is invisible and doesn't take up space).
https://github.com/musescore/MuseScore/pull/2720
No bad effect on Windows (which doesn't have PulseAudio). I guess this change should go into 2.0.4 too
Fixed in branch master, commit 58675ebbed
fix #117301 PulseAudio QGroupBox min height
Make sure that the PulseAudio QGroupBox covers at least the bottom edge of the PulseAudio checkbox with consistent margin. Purely cosmetic fix, so doesn't look unprofessional.
Fixed in branch master, commit 9221bbea70
Merge pull request #2720 from ericfont/117301-PulseAudioQBox
fix #117301 PulseAudio QGroupBox min height
Fixed in branch 2.0.4, commit a5f2547491
fix #117301 PulseAudio QGroupBox min height
Make sure that the PulseAudio QGroupBox covers at least the bottom edge of the PulseAudio checkbox with consistent margin. Purely cosmetic fix, so doesn't look unprofessional.
Automatically closed -- issue fixed for 2 weeks with no activity.