Change in Style > General causes loss of all customised staff text properties
2.1-dev: cf5a1d7 / Win 7
Seems to be a very new bug. Open the attached score. Make any change in Style > General.
Result: All user-customised staff-text properties in the score are lost.
| Attachment | Size |
|---|---|
| staff_text_bug.mscz | 16.12 KB |
Comments
I observe a change on May 20, 2016 in branch master (and so, since December 12 in branch 2.1)
- With this nightly, behavior as 2.0.3: 49e71c3
- With the next one: the current result: 8604467
It's due to the fix of #102716: Font doesn't automatically update itself after loading style ... We need to choose... or we do want text style to apply to text when the style change or we don't...
So either this or #102716: Font doesn't automatically update itself after loading style
It's the same for #102716: Font doesn't automatically update itself after loading style. With the proposed fix it will force fonts and other style settings to every single text elements, even the ones already customized and it's not undoable...
It seems to me the correct behavior would be for Text::styleChanged() to not just blindly call setTextStyle() on the text, but to instead do the whole "rebasing" procedure I could swear I remember us using elsewhere to update the defaults but keep customization. But I can't actually find where we do this.
Fixed in branch 2.1, commit 3ee8fca91e
Fix #183946
Revert "#102716: text isn't correctly updated when loading style"
This reverts commit a823ba5a5ab016a27412459476ad5472cfcae63a.
Automatically closed -- issue fixed for 2 weeks with no activity.