Languages

Undo.h: Lots of warnings about non-virtual destructor

perholje

• Jul 17, 2009 - 20:44

Type

Functional

Severity

Status

closed

Project

MuseScore

When I build MuseScore from SVN trunk the compiler emits lots of warnings against most (if not all) of the classes in undo.h, inheriting from UndoCommand. "the class ... has virtual functions but non-virtual destructor".

As far as I can see this has a really easy fix - add the virtual keyword to the destructor of UndoCommand.
I have attached a patch.

Attachment	Size
undocommand_virtual_destructor.diff_.txt.txt	439 bytes

Comments

[DELETED] 5

• Jul 17, 2009 - 22:44

Severity

⇒

Thanks for the patch. I tested on windows and it looks ok. I commited in r1938

David Bolton

• Jul 25, 2009 - 06:24

Severity		⇒
Status (old)	patch (ready to commit)	⇒	fixed

I assume it is safe to mark this as fixed (since the patch is committed).

Thomas

• Aug 8, 2009 - 06:29

Severity		⇒
Status (old)	fixed	⇒	closed

Automatically closed -- issue fixed for 2 weeks with no activity.