Missing naturals when switching key [DELETED] 3 • Jan 3, 2018 - 14:51 Reported version 3.0 Type Functional Severity S4 - Minor Status closed Project MuseScore Tags newlayout 3.0alpha 3.0alpha-06 Regression in visual test accidental-10: Naturals are missing. Expected: Actual: Reply Comments Marc Sabatella • Jan 3, 2018 - 17:22 FWIW, I noticed this when I was working on #267602: Measure shifts back and forth with each layout. Also see #251706: Changing key signature after section break on horizontal frame force a courtesy key signature.. The code for all of these is related. I think the changes I made should be good for master once the current here is fixed, but I couldn't test. if fixing this does show the others are fixed as well, then we can close #251706: Changing key signature after section break on horizontal frame force a courtesy key signature. (the other is already marked closed). Reply [DELETED] 5 • Jan 9, 2018 - 09:27 Tags View Changes Reply Anatoly-os • Apr 2, 2018 - 07:03 Tags View Changes Reply mattmcclinch • Apr 12, 2018 - 04:43 Status (old) active ⇒ patch (code needs review) Status active ⇒ See https://github.com/musescore/MuseScore/pull/3624. Reply Git Message • May 7, 2018 - 15:36 Status (old) patch (code needs review) ⇒ fixed Status ⇒ fixed Fixed in branch master, commit 4c8dbaa9fc fix #268122: Missing naturals when switching key Reply Git Message • May 7, 2018 - 15:36 Fixed in branch master, commit d2926ae660 Merge pull request #3624 from mattmcclinch/268122-missing-naturals fix #268122: Missing naturals when switching key Reply System Message • May 22, 2018 - 10:00 Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Marc Sabatella • Jan 3, 2018 - 17:22 FWIW, I noticed this when I was working on #267602: Measure shifts back and forth with each layout. Also see #251706: Changing key signature after section break on horizontal frame force a courtesy key signature.. The code for all of these is related. I think the changes I made should be good for master once the current here is fixed, but I couldn't test. if fixing this does show the others are fixed as well, then we can close #251706: Changing key signature after section break on horizontal frame force a courtesy key signature. (the other is already marked closed). Reply
mattmcclinch • Apr 12, 2018 - 04:43 Status (old) active ⇒ patch (code needs review) Status active ⇒ See https://github.com/musescore/MuseScore/pull/3624. Reply
Git Message • May 7, 2018 - 15:36 Status (old) patch (code needs review) ⇒ fixed Status ⇒ fixed Fixed in branch master, commit 4c8dbaa9fc fix #268122: Missing naturals when switching key Reply
Git Message • May 7, 2018 - 15:36 Fixed in branch master, commit d2926ae660 Merge pull request #3624 from mattmcclinch/268122-missing-naturals fix #268122: Missing naturals when switching key Reply
System Message • May 22, 2018 - 10:00 Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
FWIW, I noticed this when I was working on #267602: Measure shifts back and forth with each layout. Also see #251706: Changing key signature after section break on horizontal frame force a courtesy key signature.. The code for all of these is related. I think the changes I made should be good for master once the current here is fixed, but I couldn't test. if fixing this does show the others are fixed as well, then we can close #251706: Changing key signature after section break on horizontal frame force a courtesy key signature. (the other is already marked closed).
See https://github.com/musescore/MuseScore/pull/3624.
Fixed in branch master, commit 4c8dbaa9fc
fix #268122: Missing naturals when switching key
Fixed in branch master, commit d2926ae660
Merge pull request #3624 from mattmcclinch/268122-missing-naturals
fix #268122: Missing naturals when switching key
Automatically closed -- issue fixed for 2 weeks with no activity.