Zerberus: OGG samples are being normalized

• Jun 11, 2018 - 01:08
Reported version
2.3
Type
Functional
Severity
S3 - Major
Status
closed
Project

In recent builds of MuseScore, Zerberus is normalizing all OGG samples, which causes major issues with sample balance and throws off dynamic programming of instruments with multiple velocity layers.

Steps to reproduce:
1. Load the attached MuseScore project.
2. Follow the directions at the top of the score to load the samples.
3. Play the project.

Result: You hear two wood blocks at the same volume.
Expected result: The second wood block should be much quieter than the first.

Did the normalization of OGG files began as a response to issue 271718: zerberus: frequent clicking noises when playing samples? If so, it is not really the right approach. Keep in mind that I am already adjusting all OGG files I create with 1 dB headroom, which eliminates the possibility of the clicks we were experiencing when a waveform reached max volume.

Attachment Size
Zerberus_volume_test_03.zip 51.73 KB

Comments

Status (old) active fixed
Status active fixed

Fixed in branch 2.3, commit ccc839cbef

fix #273245: all ogg samples are normalized

Remove normalization if max float sample value is lower than 1.f.