Saving file with invisible rehearsal mark deletes it TheOtherJThistle • Sep 18, 2018 - 19:02 Reported version 3.0 Type Functional Severity S3 - Major Status closed Project MuseScore Tags 3.0alpha2 Reproduce: Add a rehearsal mark at any point in a new score Uncheck 'visible' in the inspector Save the file and close Load the file The rehearsal mark will have disappeared Reply Comments TheOtherJThistle • Sep 18, 2018 - 19:06 Update: this happens with any TextBase-derived element. Reply TheOtherJThistle • Sep 18, 2018 - 19:33 Further update: this an issue to do with reading, not writing. I'm trying to work out where exactly it's coming from. Reply Git Message • Sep 19, 2018 - 09:27 Status (old) active ⇒ fixed Status active ⇒ fixed Fixed in branch master, commit 1f133d3777 fix #276326 Saving file with invisible rehearsal mark deletes it Reply Anatoly-os • Sep 20, 2018 - 09:15 Status (old) fixed ⇒ patch (ready to commit) Status fixed ⇒ PR created Tags View Changes relates to #275361: Hidden dynamic symbols become visible 2.X->3.0. I will revert the Werner's fix and apply more general fix from https://github.com/musescore/MuseScore/pull/3966 Reply Git Message • Sep 20, 2018 - 09:15 Status (old) patch (ready to commit) ⇒ fixed Status PR created ⇒ fixed Fixed in branch master, commit 218b98eff4 Revert "fix #276326 Saving file with invisible rehearsal mark deletes it" This reverts commit 1f133d377756bb123c28595a15caab53cdd6e6f2. Reply Jojo-Schmitz • Sep 20, 2018 - 09:18 Status (old) fixed ⇒ patch (ready to commit) Status fixed ⇒ PR created Reply Anatoly-os • Sep 20, 2018 - 09:19 Status (old) patch (ready to commit) ⇒ fixed Status PR created ⇒ fixed Merged Reply Jojo-Schmitz • Sep 20, 2018 - 09:20 Actually that PR got merged too meanwhile Reply System Message • Oct 4, 2018 - 10:00 Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
TheOtherJThistle • Sep 18, 2018 - 19:06 Update: this happens with any TextBase-derived element. Reply
TheOtherJThistle • Sep 18, 2018 - 19:33 Further update: this an issue to do with reading, not writing. I'm trying to work out where exactly it's coming from. Reply
Git Message • Sep 19, 2018 - 09:27 Status (old) active ⇒ fixed Status active ⇒ fixed Fixed in branch master, commit 1f133d3777 fix #276326 Saving file with invisible rehearsal mark deletes it Reply
Anatoly-os • Sep 20, 2018 - 09:15 Status (old) fixed ⇒ patch (ready to commit) Status fixed ⇒ PR created Tags View Changes relates to #275361: Hidden dynamic symbols become visible 2.X->3.0. I will revert the Werner's fix and apply more general fix from https://github.com/musescore/MuseScore/pull/3966 Reply
Git Message • Sep 20, 2018 - 09:15 Status (old) patch (ready to commit) ⇒ fixed Status PR created ⇒ fixed Fixed in branch master, commit 218b98eff4 Revert "fix #276326 Saving file with invisible rehearsal mark deletes it" This reverts commit 1f133d377756bb123c28595a15caab53cdd6e6f2. Reply
Jojo-Schmitz • Sep 20, 2018 - 09:18 Status (old) fixed ⇒ patch (ready to commit) Status fixed ⇒ PR created Reply
Anatoly-os • Sep 20, 2018 - 09:19 Status (old) patch (ready to commit) ⇒ fixed Status PR created ⇒ fixed Merged Reply
System Message • Oct 4, 2018 - 10:00 Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
Update: this happens with any TextBase-derived element.
Further update: this an issue to do with reading, not writing. I'm trying to work out where exactly it's coming from.
Fixed in branch master, commit 1f133d3777
fix #276326 Saving file with invisible rehearsal mark deletes it
relates to #275361: Hidden dynamic symbols become visible 2.X->3.0. I will revert the Werner's fix and apply more general fix from https://github.com/musescore/MuseScore/pull/3966
Fixed in branch master, commit 218b98eff4
Revert "fix #276326 Saving file with invisible rehearsal mark deletes it"
This reverts commit 1f133d377756bb123c28595a15caab53cdd6e6f2.
Merged
Actually that PR got merged too meanwhile
Automatically closed -- issue fixed for 2 weeks with no activity.