Cannot change instrument name or hide them in parts

• Jan 6, 2019 - 16:08
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
active
Regression
Yes
Workaround
No
Project

In version 2.x it was possible to change long and short instrument names from the parts. It was also possible to hide instrument names on individual staves, both in parts and scores. This is now impossible in version 3.

From a part:

  • Right click the part name or staff and select Staff/part properties
  • Change the long instrument name
  • click OK

Result, nothing changes, if you open staff/part properties again the change is undone. If you do it from the main score, both the main score and parts is affected.

See discussion in https://musescore.org/en/node/281279.


Comments

It's been observed that with my change now making it possible to delete instrument names, there is unfortunately a crash on undo. This is because we are trying to re-establish the selection, and the old instrument is no longer valid - a new one has by then been generated to replace it. Probably the fix is to somehow suppress the re-establishing of selection. Somehow this doesn't seem to be a problem when deleting other quasi-generated elements - undo simply doesn't re-establish the selection which beats crashing for sure.

In reply to by Marc Sabatella

If restoring a selection is an issue it probably needs to be disabled here. We can safely restore selection for elements that are not recreated on layout or deleted automatically in some other way so there is a limited number of element types there which are allowed to be restored in selection. Excluding InstrumentName from that condition should work, at least until some more proper solution is established on better selection restoration or better marking of "volatile" elements.