Regression: display of beam properties for a selected note

• Jan 16, 2019 - 17:49
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Few
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project
Tags

In version 2.x, when you selected a note and opened the beam properties palette, the current beam property of the note (e.g. "beam start", "auto beam", etc.) would be highlighted. This does not happen in version 3.


Comments

Status fixed active

Thanks for taking this on! It's somewhat of an improvement, but it only works for selection by clicking, not for any other means of selection (eg, cursor). So it ends up being more misleading than not showing anything, I'm afraid. I'd recommend going back to your original approach of doing it in MuseScore::endCmd(), and then keep the existing call you have only to catch the clickOffElement case.

Sorry I didn't have comments this detailed earlier, was hoping someone who knew this code better would do so.

In reply to by Marc Sabatella

You’re right! I actually had code to cover special bases which was why my function had the default parameter value of false, but for some reason when I did my final testing before the PR I ended up removing one of the function calls thinking it was unnecessary. Also by cursor, do you mean like using the left and right arrows? Thank you for the reminder, I will fix it when I get home or when I get the chance.

Great! Yes, I mean left/right arrow keys, there are various other similar commands to that can result in the selectin changing. As long as the selection is a single note or rest (easy to check, ask on telegram if you need help). the beam palette should be updated.

Status active PR created

https://github.com/musescore/MuseScore/pull/4766

Alright I fixed the issue and found another issue along the way that I fixed too. Upon deselection of the element where clickOffElement isn't set to true, I never updated the UI so it didn't show that no valid chordRest is selected until you hovered over the cells or changed the selection. I did have to do it in Musescore::endCmd() instead of Musescore::selectionChanged() based on my current knowledge though. I have a bit more explaining why in the pull request. Thank you for your help!

Fixed in branch master, commit 3472631b31

_Merge pull request #4766 from peterhieuvu/281957-beamproperties

fix #281957 move highlight update to work for cursor changes and on click of elements that aren't notes_

Fixed in branch 3.0.5, commit 2ef2bf50f1

_Merge pull request #4766 from peterhieuvu/281957-beamproperties

fix #281957 move highlight update to work for cursor changes and on click of elements that aren't notes_