Format / Style / Text Styles showing incorrect size values for some styles

• Feb 17, 2019 - 01:11
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
active
Regression
No
Workaround
Yes
Project

Version: 3.0.2

Some styles behave weird. When I go to Format → Style, select Text Styles, I end up with Title preselected at Gentium 24 pt (in my style). Then I go to Volta, and I still see Gentium 24 pt. It saves as Free Serif 8 pt though. If I change the size, it sometimes(?) seems to stick. I haven’t exactly figured out what all is wrong and what all works, and what all styles are affected.

Editing the .mss fixes this, though, which is what I did.


Comments

Are you saying Gentium 24 pt is not correct for Title in your score? Or it is correct for Title but not for Volta? Can you attach a score and precise steps to reproduce a problem?

In reply to by Marc Sabatella

It’s correct for Title, but not for Volta. I changed the font but kept the sizes (mostly, but in all the styles relevant for this issue, I did).

The problem is basically that, when you switch from a “working” style (such as Title) to a “non-working” one (such as Volta), some things from the previous style are kept.

Priority P0 - Critical

OK, I see what you mean. From Format / Style / Text Styles, first click Title, then click Volta - the text size info does not change as it should. This is true for most of the text styles from TextLine down to Hairpin. The other fields do seem to update, just not the size.

Probably a question of some styles inheriting the overall text default.

The problem is that the font settings for the lines (voltas etc) are handled a bit differently as there are no actual text elements using these styles - instead, line text settings control text within the lines (potentially different texts for begin, continue, and end). It's that handling that is a bit off in this dialog. But the issue as far as I can tell is only with what is displayed on screen, the actual behavior seems correct if you try editing the style - it correctly (?) sets the BEGIN text style.

I think the simple fix is to handle Pid::BEGIN_FONT_* properties in the switch statement in EditStyle::textStyleChanged(), perhaps just doubling up on the handling of the corresponding "regular" properties (eg, combine handling BEGIN_FONT_FACE and FONT_FACE). But, smarter might be to actually set all three style variants (begin, continue, and end) when making a change here? Or not. Right now, I think the only way to control the continue and end styles is via the set as style buttons in the Inspector?