Misclicking when attempting to create a range selection causes the current selection to be lost

• Nov 21, 2019 - 18:57
Reported version
3.3
Type
Ergonomical (UX)
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
No
Workaround
Yes
Project

To reproduce: Select a note or a bar, then shift-click in empty space.

Expected behaviour: If the user is shift-clicking while they have an existing selection, it can be assumed that they're attempting to create a range selection. If they're shift-clicking empty space, it's probably a misclick (e.g. slightly missing a note which is on a ledger line). Therefore, the existing selection should be preserved, so that the user can try again.

Observed behaviour: The user's current selection is dismissed. This means that, in order to create the range selection as intended, they need to start again from the beginning.


Comments

I hope you're distinguishing "truly empty space" from "empty space on a staff", which is my normal shift-click to extend/end a range selection.

Status PR created fixed

Fixed in branch 3.x, commit 8375251fb1

_fix #297446: shift+click empty space clears selection

Resolves: https://musescore.org/en/node/297446

Currently if you have a selection and try to shift+click to extend it
but accidentally click too far above or below where you intended,
the existing selection is lost.
There is no benefit to this behavior, since the way to clear a selection
is to click, not shift+click, an empty space.
Shift+click an empty space should be harmless, as ctrl+click is.
I previously implemented the check for ctrl+click,
I simply negeclted to include shift+click.
This is fixed by changing the two tests that were detecting ctrl+click
and skipping the usual clear selection in the case,
so they instead skip the clear for both ctrl & shift click
(actually, for anything but plain click)._

Fix version
3.5.0