Crash on deleting an element being dragged

dmitrio95

• Dec 5, 2019 - 08:29

Reported version

3.3

Priority

P1 - High

Type

Functional

Frequency

Once

Severity

S2 - Critical

Reproducibility

Always

Status

closed

Regression

Yes

Workaround

Project

MuseScore

Came from a crash reporter.

1) Start dragging an element (e.g. dynamics, but this is reproducible with other elements too).
2) While holding left mouse button, press Delete.
3) Continue dragging, or just release mouse button.
Result: crash.

This is reproducible since 3.1.0 version, 3.0.5 seems to be unaffected by this.

Comments

Jojo-Schmitz

• Dec 5, 2019 - 09:07

Regression

⇒

Yes

so a regression vs 3.0.5

cadiz1

• Dec 5, 2019 - 09:35

Somewhere between this commit (March, 30) : deletion works: a9d043a

And this one (first of April 4), with crash: 5bd7e15

Howard-C

• Dec 5, 2019 - 09:54

Status

active

⇒

PR created

See https://github.com/musescore/MuseScore/pull/5512.

Git Message

• Jan 21, 2020 - 08:21

Status

PR created

⇒

fixed

Fixed in branch master, commit 6fd217c017

_fix #298141: crash on deleting an element being dragged

When the element is being dragged, it is selected, but if it's deleted, then the selection changes. This causes this in endDrag() to change to the parent element, but since the EditData parameter (ed) is still that of the deleted element, ed.getData(this) returns a nullptr which directly leads to a crash._