Selecting multiple elements with sameType but different subtype doesn't update inspector title

• Dec 10, 2019 - 09:07
Reported version
3.1
Type
Graphical (UI)
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
fixed
Regression
Yes
Workaround
No
Project

Select both a slur and a tie and the inspector's title should be "Slur/Tie", this is the behaviour in 2.3.2, and the source .ui file has indeed "Slur/Tie". But now in 3.3.4 the title only says "Slur" or "Tie" based on the element first chosen.


Comments

Title InspectorSlurTie and InspectorCaesura don't work as in 2.x Selecting multiple elements with same ElementType but different subtype doesn't update inspector title
Title Selecting multiple elements with same ElementType but different subtype doesn't update inspector title Selecting multiple elements with sameType but different subtype doesn't update inspector title

By the way, is it really necessary to have a different inspector title for each breath or caesura? The title distinguishes breath from caesura, that's all it need to do! But right now with accessibleInfo() being the title, it in reality appears to be "Breath mark (comma)", "Breath mark (tick-like)" and so on. I think the information in the blanket is not really needed, maybe a judgement of isBreath() or isCaesura() is enough, and the title being either "Breath" or "Caesura".

And with this PR, there's another "problem" because of this: even if no more than two different types of breathes or caesuras are selected, the title becomes "Breath/Caesura" while one of the types isn't even selected.

Status PR created fixed

Fixed in branch master, commit a5de5b78a8

_fix #298363: selecting multiple elements with sameType but different subtype doesn't update inspector title

Resolves: https://musescore.org/node/298363.

From 2.x to 3.x, a change was made which leaded to the issue: if oSameTypes != sameTypes, inspectors will not be updated. Even if slur and tie/breath and caesura/articulation and ornament are both selected, for each group sameType will continue to give true, and so the inspector is not updated.

This patch adds another field: sameSubtypes. If sameTypes is true but the subtypes are different, the inspector will be updated too._

Fix version
3.4.0