Grace note value change does not propagate to linked staves and is not properly undoable

• Aug 17, 2014 - 00:47
Type
Functional
Severity
S4 - Minor
Status
closed
Project

1. Open attached score (produced in 1.3).
2. Click on notehead of grace note.
3. Change value (e.g. 16th).
4. Undo.

Expected result: The value is 8th.
Actual result: The value is 16th.

Note: Only affects pitched and drumset staves. It is also reproducible in 2.0 scores.

Using MuseScore 2.0 Nightly Build (2bb5183) - Mac 10.7.5.


Comments

Title Cannot undo grace note value change on pitched and drumset stave Grace note value change does not propagate to linked staves and is not properly undoable
Status (old) active patch (ready to commit)

I discovered that a change to grace note duration does not propagate to linked staves/parts either, for the same underlying reason - the duration change was being performed directly rather than using undoChangeChordRestLen(). Presumably that is because the latter function was not grace-note-aware, but I have modified it so it is, leveraging the same code I added to support ties to/from grace notes (see #6535: Impossible to tie to a grace note).

PR with this code: https://github.com/musescore/MuseScore/pull/1487