Undoing slur addition to a range only removes one slur

• Feb 25, 2020 - 14:23
Reported version
3.4
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
No
Workaround
Yes
Project

Select a range with more than one staves, press S, make sure more than one staves have slurs, then undo (Ctrl+Z). Only one slur is removed. Expected behaviour is all slurs being removed, since they're all added at once.


Comments

Status PR created fixed

Fixed in branch master, commit 7e185d280e

_fix #301605: Undoing slur addition to a range only removes one slur

Resolves: https://musescore.org/en/node/301605.

Prior to this commit, ScoreView::cmdAddSlur() could be called multiple times from within ScoreView::addSlur(), resulting in the need for multiple "undo" commands to completely undo a single "add-slur" command. This commit swaps the names of these two functions, and, more importantly, only calls Score::startCmd() and Score::endCmd() once for the entire operation._

Fix version
3.5.0