Grey out redundant controls from the mixer window

• Aug 23, 2014 - 12:30
Type
Graphical (UI)
Severity
S4 - Minor
Status
PR created
Project

The addition of a specialist effects section has made the effects controllers in the mixer window redundant.

As David Bolton notes in issue #22683: Mixer Reverb and Chorus have no effect on sound

I will look at what is required to remove these, but I may need help with the finding and removal of consequent redundant code - any pointers here welcome


Comments

Why "Remove redundant controls" instead of "Repair broken controls"?
As I understand, Master Effects affects *all* staves (that's why it is Master, right?) and adding reverb and chorus to a staff via mixer could be considered as a feature.

Also since we have now JACK support, we have to deal with it. These controls are not redundant for JACK, see my comment here: http://musescore.org/en/node/22683#comment-125391

Because the effects chain no longer goes through the mixer.

You now control the wet/dry mix direct from Zita - you can no longer control the reverb or chorus sends and returns in the way we used to in MuseScore.

This isn't to say that we shouldn't in the future, but to save getting 100's of error reports about controls not working in the mixer it would be better to remove them for the beta and MuseScore 2 release until the code can be written to allow insertion of effects on the tracks themselves.

Think in terms of a real mixer - if there are no track effect sends you can only control effects at master level, and this is currently the case with MuseScore 2

"Because the effects chain no longer goes through the mixer."
By new design or it is broken?
If it was broken as a regression - couldn't it be repaired (re-implemented) before release?
As I see, control messages are sent from reverb/chorus to internal sequencer and Fluid just ignores them (Have it ignored before?).

"Think in terms of a real mixer - if there are no track effect sends you can only control effects at master level, and this is currently the case with MuseScore 2"
Yes, I understand you. I just wanted to say that repairing these controls probably might be better than removing and re-implementing again.

Status (old) active patch (code needs review)

As I understand it it was a deliberate design choice by the development team, the idea is that users will be eventually be able to add different effect plugins to the master effects rack

I think maybe the way forward is to grey these controls out unless Jack MIDI is selected as the output. It should be pretty simple to toggle the enabled state in the widget when Jack MIDI is selected as the output.

I shall be submitting this as a pull request shortly. It is available from the working branch (NewSplashscreen) in my clone of the MuseScore GitHub repository....
https://github.com/ChurchOrganist/MuseScore/commit/77d9f08024e7c3ecf0d9…

Title Remove redundant controls from the mixer window Grey out redundant controls from the mixer window
Status (old) patch (code needs review) patch (ready to commit)

Pull request #1209 sent

Title amended to reflect issue with Jack MIDI out better