Key signature change to C major adds extra space after the clef in error
Reported version
3.5
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.5.2.311459983, revision: 465e7b6
Open the attached score. Look at the start of system 3 (M9). Here the key sig. changes to C major. Extra space has been added, in error, between the clef and the time sig.
Contrast this with the start of the piece which is also in C major. Here the space between the clef and time sig. is as expected.
| Attachment | Size |
|---|---|
| gap_clef_time_sig.mscz | 6.78 KB |
Fix version
3.6.0
Comments
Seems the culprit is the time signature change that coincides with the key signature change?signature
Sometimes there is an actual element there representing the C major key signature, sometimes there isn't, that probably explains the difference. Usually none is needed at the beginning of the score, one is for a key change. But we should find a way to skip the spacing if the key signature is empty.
A related issue: Create a A Major key signature in measure one by dragging the
![Screenshot_20201104_200334.png]( "Screenshot_20201104_200334.png")
KeySigto that measure 1. Next, delete it by dragging a C MajorKeySigto measure one. Now we see a similar phenomena:Now save the file, close the score and reload the file. The
![Screenshot_20201104_200522.png]( "Screenshot_20201104_200522.png")
KeySigis gone and theTimeSigis shifted to the left:@njvdberg you probably already realize this, but your PR https://github.com/musescore/MuseScore/pull/6811 has the bones of a fix for this as well, if you simply treat C major key as invisible in allElementsInvisible().
In reply to @njvdberg you probably… by Marc Sabatella
That was exactly what I planned to do (when that PR is fixed up) :-).
PR https://github.com/musescore/MuseScore/pull/6811 now solves this issue too.
Fixed in branch 3.x, commit c8b7f22b57
_Fix #312393 - Key signature change to C major adds extra space after the clef in error
Consider a segment invisible if all elements are invisible or have a width of zero._
Fixed in branch 3.x, commit fc5093290b
_Merge pull request #6811 from njvdberg/issue-299196-invisible-timesig-spacing
Fix #299196 Fix #312393 - Missing space between key signature and first note if time signature is hidden_
Fixed in branch 3.6alpha, commit c8b7f22b57
_Fix #312393 - Key signature change to C major adds extra space after the clef in error
Consider a segment invisible if all elements are invisible or have a width of zero._
Fixed in branch 3.6alpha, commit fc5093290b
_Merge pull request #6811 from njvdberg/issue-299196-invisible-timesig-spacing
Fix #299196 Fix #312393 - Missing space between key signature and first note if time signature is hidden_
Automatically closed -- issue fixed for 2 weeks with no activity.