identical expression

maddin200

• Dec 29, 2020 - 15:57

Type

Functional

Frequency

Once

Severity

S4 - Minor

Reproducibility

Always

Status

closed

Regression

Workaround

Project

MuseScore

/src/importexport/internal/midiimport/importmidi_simplify.cpp line 44
Code:
ReducedFraction sum(0, 1);
for (const auto& d: durations) {
sum += ReducedFraction(d.second.fraction()) / d.first;
}
return desiredLen == desiredLen; // <-- identical expression

Comments

Jojo-Schmitz

• Dec 29, 2020 - 16:10

Same code in 3.x.
I guess (!) is rather should be return sum == desiredlen;, but I'm not really sure.
That function/method is used in some Q_ASSERT_X().

So that code is used only in DEBUG mode, never in any released version of MuseScore

Jojo-Schmitz

• Dec 29, 2020 - 16:14

Status

active

⇒

PR created

See https://github.com/musescore/MuseScore/pull/7179 (for 3.x)
And https://github.com/musescore/MuseScore/pull/7180 (for master)

Jojo-Schmitz

• Dec 29, 2020 - 16:28

BTW: it might be helpful if you'd report all these in one go rather than little by little ;-)

maddin200

• Dec 30, 2020 - 09:48

only one more found:

[D:/Data/OpenSource/MuseScore-master/src/libmscore/textbase.cpp line 1983
Code:
if (r->height() == 0) {
r = &_layout[i - i].boundingRect(); // <- - same index
}

Jojo-Schmitz

• Dec 30, 2020 - 10:29

Hmm, r = &_layout[i-i].boundingRect(); is the same as r = &_layout[0].boundingRect();, but I wonder whether it is actually meant to be r = &_layout[i-1].boundingRect(); and whether that code just works by accident?
In 3.x too, but at libmscore/textbase.cpp, line1796