Partname doesn't get shown on the part if it consists of more than one instrument

• Sep 19, 2014 - 15:34
Type
Functional
Severity
S4 - Minor
Status
closed
Project

Partname doesn't get shown on the part if it consists of more than one instrument, e.g. a score with a closed (2 staves) SATB and Piano, parts being created for Piano and Choir.
On the Piano part the word "Piano" is shown, on the Choir part it is not.
Looking into the file shows that the corresponding section in the header's VBox is missing for the Choir part.


Comments

It seems what gets displayed in the upper left is the "Instrument Name" (from staff properties) of the first staff in the part. This doesn't really make sense to me, and I started a discussion about this once before, but it didn't seem to go anywhere. I can't seem to find it, unfortunately.

Sounds like you are describing behavior different from what I just wrote, though. Could you post a ample score / steps?

Looks like you got exactly what I meant. Of course "Choir" is not the instrument name, it isn't even the 'partname' in the sense of MuseScore's internals (would be "Soprano/Alto" and "Tenor/Alto" when using the closed score SATB template), but is clearly what I named the part when generating the parts. See attached, created from the template 02-Choral-SATB_Closed_Score_with_Piano.mscx.
It seems to take the Long Instrument Name of the first Instrument in the part.
The tabs have wrong names too, for SA it is Alto, should be Soprano/Alto, for TB it is Bass, should be Tenor/Bass, It did show Soprano/Alte and Tenor/Bass on the generate parts dialog, but going back in it Shows Alto resp. Bass now.

This was slightly different with my real life score, where nothing was shown on the part, but that was imported from 1.3 and no Long Instrument Name was set.

It should take the name you pick in the generate parts dialog (and default to the part name, possibly fallback to Long Instrument name), for both the part's tab and the corresponding field in the part.

Another, related, issue: the partname collides with the Lyricist/Poet/Texter, I'd rather have it below that, or somewhere else where it doesn't usually collode, could also be upper left Corner.

Attachment Size
Test.mscz 6.17 KB

Wish I could find that thread; I attempted to break down which name controls what and how I propose it be changed.

What seems to be the case is this:

File / Parts / Part title - this controls the name of the *tab* for the part in the score window; I think it also controls the filename when exporting?

Staff Properties / Part name - this controls the name displayed in the Mixer

Staff Properties / Long instrument name - this controls both the staff name for the first system in the staff within the score and *also* the name in top left corner of any part that contains this instrument as the first staff

Staff Properties / Short Instrument Name - this controls the staff name for systems after the first within the score

I propose that "Part title" be used for the top-left-corner name. Either that or the "Part name" of the first staff, but I think that's less ideal. And if "Part name" is literally only used in the Mixer, this could be changed to something like "Mixer channel name".

There is also Staff Properties / Instrument name

File / Parts / Part title can't get edited after the part has been created and does not persiste if you name it "Soprano/Alto", but bemoves just "Alto", maybe because it is related to the filename for that part and "/" in filename is a no-go? Seems to be the case, "Soprano+Alto" works

Yes, there is also "Staff Properties / Instrument name". That one is read-only, and just reflects the whatever was in instruments.xml - the entry you selected when you added the instrument. I don't think it gets used for anything else, although I could be wrong.

Part titles (= tab names) indeed can't be edited after the fact, which is a shame. Actually, *nothing* about already created parts can be edited. I seem to remember this was formerly possible, but maybe not.

I was wondering why you names those parts "Alto" & "Bass" :-). What you say about "/" makes sense.

There got to be a better method... a "/" should be a perfectly legal character for the title of a tab, where the heck does it get removed?
I do now have a solution for sanitizing filenames when actually doing the export parts, so that should take care of that "/", but I can't find where it gets removed from partName to make up for the title of the part tab, any hints or pointers?

Hmm, I might hav found it, the tabs get added and updated in mscore/scoretab.cpp with
tab2->addTab(excerpt->score()->name().replace("&","&&"));
and that name() is in libmscore.shore.h:
QString name() const { return info.completeBaseName(); }
Which would indeed have the effect of removing everything up to and including the last /

Guess we could replace the '/' in mscore/exceptsdialog.cpp, ExcerptsDialog::createName() already?
"&", "+", " ", "-" or "_"?