Add a staff to an other which contains a local time signature causes a crash

• Dec 27, 2014 - 14:22
Type
Functional
Severity
S2 - Critical
Status
closed
Project

Nightly December 26: 273bd61 / Windows 7

1. On "My First Score" , fill the first measure (4/4) with some notes, or open this file : Test Add a staff.mscz

2. Drag and drop a local time signature 3/4 (with Ctrl) in the second measure – no need to fill with notes.

3. « I » → Select first staff → Add a staff (bass clef) → Ok

Result : crash

It's probably related with this issue: #41796: Crash when adding a Global time sig into a measure which is in Local time sig. But it is not a duplicate, because the simple fact to add a local Time Sig in a staff causes a crash by adding an other staff.

An additionnal proof ? With this specific scenario, the crash occurs a few months earlier.

More precisely between July 29 with this Nightly, correct: ccb04e0
- test on ccb04e0 July 29.jpg

- and this one, on July 30, with a failure: e7e9d9f
failure on 7e9d9f July 30.jpg
For fix this issue: #25876: Local time signatures have incorrect beaming and can cause score corruption

So the origin maybe is here: https://github.com/musescore/MuseScore/commit/bc891168eb43e459685a7c045…

or/and here, less likely? https://github.com/musescore/MuseScore/commit/f7bea5e2671460ffd98a56c21…

- Note that there is no crash by adding a linked staff, but the corruption is always underlying by mixing afterwards different types of TimeSig (local / global), e.g:

1 measure 4/4 global + 1 measure 3/4 local + 1 measure 4/4 global, with bad consequences later.


Comments

I noticed that in the commit you flag as "correct" (ccb04e0), the application doesn't crash just after adding the staff, but if you try to add a note to the second measure of the first staff (ie the measure with the local time signature), it crashes too.

Not sure if these issues are related though, I'll try to investigate a bit.

I don't see the same thing as you with this Nightly: ccb04e0

I confirm that there is no crash after adding a staff, even adding a note or more in this first staff and second measure (with local time signature) and followings, as you can see.
2 flutes.jpg

This is odd, because I don't expect it to be palteform dependent (I'm using linux).
To be a little bit more precise, I must say that the crash occurs when I click on the second measure of the first staff right after adding the second shaft. I've managed to add notes in it though, as you shown, but I had to use keyboard shortcuts.

BTW, I confirm that the first commit leading to immediate crash is the one you pointed out, bc891168eb43e459685a7c045bf4c1f802e8e83e

Sorry, I don't see still no crash, by selecting the second measure after adding the second staff (as on attached image)
select.jpg