Adding hyphen removes melisma of next lyric

• Jan 29, 2015 - 05:17
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

1. Open attached score (produced in 1.3).
2. Double-click the word "In"
3. Type hyphen.
4. Click somewhere (exiting 'edit mode').

Result: Melisma is removed.

Note: This is also reproducible in a 2.0 score.

Using MuseScore 2.0 Nightly Build c169cc2 - Mac 10.7.5.

Attachment Size
Adding hyphen removes melisma of next lyric.mscz 1.45 KB

Comments

• Jan 30, 2015 - 02:47

FWIW, this is not a (recent) regression; it was this way in Beta 1, and in fact in 1.3 as well. As it happens, the code responsible for this is also the code that was responsible for deleting the melisma when you hit space after leaving a melisma syllable, but only if the syllable was preceded by a hyphen. It was curious code to begin with, that function is now handled (correctly) by Miwarre's code, and I see no reason not to simply remove this code. Or at least, to test this further and make sure I'm not missing something.

Reply

• Jan 30, 2015 - 03:52
Status (old) active ⇒ patch (code needs review)

https://github.com/musescore/MuseScore/pull/1709

Actually, almost the whole ScoreVierw::lyricsEndEdit() is useless, it seems to me. But something else I discovered while testing: hyphen does not remove an underscore from the syllables you are *leaving*. That is:

1) double click some one-syllable word with a melisma line
2) press "-"

Result: the melisma line remains, no hyphen appears. if you try entering another syllable on the next note, you end up with a syllable and a melisma line extending right through it:

melisma-under.png

So it's actually kind of backwards - the melisma line is deleted when we *approach* a melisma syllable by dash, but not when we *leave* it. Unless I'm missing something, it should be the other way around. Again, there's nothing new about this - it was this way in Beta 1 as well as in 1.3.

Would love a sanity check on my fix.

Reply