New Inspector control: Select Notes in the Element Group section
Ubuntu 14.04, GIT commit: 4eda1f6
Currently, if there is a range selection, only the Element Group section of the Inspector displays. I get why, and I know you can then right click a note and choose "Select / All similar elements in range selection" to convert to a list selection and thus gain access to the Note & Chord section of the Inspector. But this is non-obvious, and it seems it should be doable directly from the Inspector.
BTW, I tried to implement something a few months ago where the Notes section would display anyhow and only operate on the notes, it ended up having issues as some note properties were also used by other element types but in different ways, and it seems there was resistance to that type of change, so I gave up in.
A simple button in the Inspector to alter the selection in this way seems very straightforward and worth doing for 2.0. I am going to look at it.
Comments
https://github.com/musescore/MuseScore/pull/1758
Fixed in 5e17e5ba9c
Hmm, why isn't it translated? I'm sure I did translate "Rests" into German (apparently "Select" and "Notes" didn't need to get translated) and updated to the latest translation, still I see "Select", "Notes" and "Rests" in that dialog
Also there seems to be a bug: select a bar with notes only, then use the Select-> Rests button in Inspector, Inspector now claims nothing to be selected, yet the notes (and lyrics and chord symbols, etc.) are still selected and a Del deletes them
If you use Select->Notes though, the lyrics, chord symbols, etc get deselected, but still a Del deletes them.
I don't know enough about how the translation system works to say why that isn't working. As far as I can see, it's correct in the code, is it not?
You are right about the Rests button not working correctly if there are no rests. I'll fix that.
I don't understand the second part, though. When I select a measure with notes & chord symbols, the chord symbols are deselected when I press "Notes" but stay behind if I then hit Delete. Lyrics are deleted when the notes they are attached to are deleted. This is not unique to my change; it's how selection & deletion of chord symbols & lyrics have always worked.
Can't see anything wrong in the code, translation wise. Maybe something is wrong between Transifex and the server where the resource manager gets it updates from.
Haven't tested, but it is possible the the opposite don't work properly either, selecting a measure with no notes, select notes, rests stay selected?
Not sure about the chord symbols. But if the lyrics are still affected by the selection, shouldn't they stay selected?
I see your latest commit fixes the no rests as well as the no notes case.
Guess the lyrics getting deleted regardless not being selected is unavoidable.
The corresponding case for the Notes button was broken in the same also, but it would be very unlikely it would have been hit, since selecting a measure with no notes really just means selecting rests, so you'd be in the Rests portion of the Inspector, not the portion for mismatched groups. Meaning this control wouldn't have displayed.
As for selecting notes but lyrics, again, this isn't unique to my code. You can select notes but not lyrics manually too, by ctrl+clicking the notes. The lyrics are truly not selected, so it would be wrong to show them highlighted. You can, for instance, hit "V" to hide the notes and it will leave the lyrics visible. The lyrics are truly not selected; it's just that MuseScore has no way to leave lyrics behind after deleting notes. It's the same with articulations or other markings attached to notes (as opposed to segments).
yep, got it...
Hmm, why the difference in behavior between selecting a measure with only rests (shows rest properties in inspector right away) and selecting a measure with only notes (need to use that select->notes button to see the notes properties in inspector)? These new buttons really only make sense when having notes and rests in a measure, don't they?
The translation issue is still there, BTW.
Rests are just rests - they are not made of individual components. So selecting a measure with rests means you have literally only rests in the selection, so the Inspector sees this as a "homogenous" selection and shows you the Rest controls. However, notes are *not* just notes - they are parts of chords, and as such, also contain stems, flags, beams, etc. So selecting a measure that contains notes is *not* actually a homogenous selection - you are selecting notes as well as stems etc. Try it with a measure containing only a whole note and you'll see you *do* get the Notes controls, because there are no stems or flags in the selection. They only go away if you select a measure that *does* contain stems, flags, and/or hooks.
One could argue that somehow selection and/or the Inspector should be smart enough to deal with this better, and I did make an attempt earlier, but it's pretty complex under the hood. It's difficult to change any aspect of how this works without breaking something else.
OK, point taken, it does look strange and inconsistent though.
Automatically closed -- issue fixed for 2 weeks with no activity.