Text properties dlg box: style change not stored

• Oct 15, 2010 - 14:35
Type
Functional
Severity
S4 - Minor
Status
closed
Project

Setup: SVN rev. 3583, Ubuntu 10.04, Qt SDK 10.02 (Qt lib 4.6.2)

Steps
1) Open any score
2) Right-click on a text (for instance the score title)
3) Select "Text properties"
4) Change the text style
5) Press [OK]
6) Re-open the text properties dlg box

Result: The text style is the same as before the change in step 4)

Expected result: style set in step 4) is recorded and put into effect.

It seems the bug is in textproperties.cpp, line 138, function TextProp::get(), where the line:
   if (unstyledGroup->isChecked() )
should read:
   if (styledGroup->isChecked() )
___________________________

Also, I suspect lines 147-154 of the same function, where font properties are read back, should be executed only if the text is not styled.

Thanks,

M.


Comments

Title [trunk r.3583] Text properties dlg box: style change not stored (w/ patch) Text properties dlg box: style change not stored
Status (old) active patch (code needs review)

It's been a while, but just incase :).