fix #105666: add support for Croatian instruments (Tambura)
As instrumentsxml.h is never touched by a C/C++ compiler, 8-bit ASCII and UTF-8 characters should never cause any kind of comapitibilty or standards compliance problems, and actually never had so far with at
least the ♭ being used in multiple places, so we can as well have ü, č and Č there too.
So fix Güiro in other places too, in C++ code in a C++11 compatible manner.
While at it fix some duplicate short instrument names and also a fix/workaround for an lupdate diagnostic
fix #105666: add support for Croatian instruments (Tambura)
As instrumentsxml.h is never touched by a C/C++ compiler, 8-bit ASCII and UTF-8 characters should never cause any kind of comapitibilty or standards compliance problems, and actually never had so far with at
least the ♭ being used in multiple places, so we can as well have ü, č and Č there too.
So fix Güiro in other places too, in C++ code in a C++11 compatible manner.
While at it fix some duplicate short instrument names and also a fix/workaround for an lupdate diagnostic
Comments
Something like the attached to get added to the plucked strings instrument group in instruments.xml
See https://github.com/musescore/MuseScore/pull/2548
Fixed in branch master, commit 158d9be498
fix #105666: add support for Croatian instruments (Tambura)
As instrumentsxml.h is never touched by a C/C++ compiler, 8-bit ASCII and UTF-8 characters should never cause any kind of comapitibilty or standards compliance problems, and actually never had so far with at
least the ♭ being used in multiple places, so we can as well have ü, č and Č there too.
So fix Güiro in other places too, in C++ code in a C++11 compatible manner.
While at it fix some duplicate short instrument names and also a fix/workaround for an lupdate diagnostic
Fixed in branch master, commit 6ee3e88b52
Merge pull request #2548 from Jojo-Schmitz/tambura
fix #105666: add support for Croatian instruments (Tambura)
Fixed in branch 2.0.4, commit ca3d3f80aa
fix #105666: add support for Croatian instruments (Tambura)
As instrumentsxml.h is never touched by a C/C++ compiler, 8-bit ASCII and UTF-8 characters should never cause any kind of comapitibilty or standards compliance problems, and actually never had so far with at
least the ♭ being used in multiple places, so we can as well have ü, č and Č there too.
So fix Güiro in other places too, in C++ code in a C++11 compatible manner.
While at it fix some duplicate short instrument names and also a fix/workaround for an lupdate diagnostic
Automatically closed -- issue fixed for 2 weeks with no activity.