add support to Croatian instruments (Tambura)

• Apr 11, 2016 - 12:41
Type
Functional
Severity
S5 - Suggestion
Status
closed
Project

see https://musescore.org/en/node/105591, it also has an instruments.xml file for inclusion.


Comments

Status (old) patch (code needs review) fixed

Fixed in branch master, commit 158d9be498

fix #105666: add support for Croatian instruments (Tambura)

As instrumentsxml.h is never touched by a C/C++ compiler, 8-bit ASCII and UTF-8 characters should never cause any kind of comapitibilty or standards compliance problems, and actually never had so far with at
least the ♭ being used in multiple places, so we can as well have ü, č and Č there too.
So fix Güiro in other places too, in C++ code in a C++11 compatible manner.

While at it fix some duplicate short instrument names and also a fix/workaround for an lupdate diagnostic

Fixed in branch 2.0.4, commit ca3d3f80aa

fix #105666: add support for Croatian instruments (Tambura)

As instrumentsxml.h is never touched by a C/C++ compiler, 8-bit ASCII and UTF-8 characters should never cause any kind of comapitibilty or standards compliance problems, and actually never had so far with at
least the ♭ being used in multiple places, so we can as well have ü, č and Č there too.
So fix Güiro in other places too, in C++ code in a C++11 compatible manner.

While at it fix some duplicate short instrument names and also a fix/workaround for an lupdate diagnostic