Minor Title bug Bomb and Kou Sheet Music • Sep 1, 2016 - 15:45 Reported version 2.1 Type Functional Severity 3 Status closed Project MuseScore When you open or switch to a new file in Musescore the title says "Musescore 2: " However upon saving a file it switches to "Musescore: " Reply Comments Jojo-Schmitz • Sep 1, 2016 - 16:04 Severity ⇒ Interesting, while I found where the title gets set to "MuseScore: <filename>" (2 places in mscore/file.cpp, line 426 and 1799), and could fix it there, I don't see where it gets set to "MuseScore 2: <filename>". Reply shoogle • Sep 1, 2016 - 16:10 @Jojo, here? Reply Jojo-Schmitz • Sep 1, 2016 - 16:18 Severity ⇒ Status (old) active ⇒ patch (code needs review) Ah, found it, mscore/musecore.cpp, lines 1756 and 1759. (@shoggle: yes, our posts crossed) See https://github.com/musescore/MuseScore/pull/2806, which should change file.cpp's title to match that of musescore cpp, i.e. "MuseScore 2: ..." Reply Git Message • Sep 3, 2016 - 09:58 Severity ⇒ Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit 1e3831860e fix #123146: window title changes after save score Reply Git Message • Sep 3, 2016 - 09:58 Fixed in branch master, commit 755cd05026 Merge pull request #2806 from Jojo-Schmitz/title fix #123146: window title changes after save score Reply Git Message • Sep 3, 2016 - 10:03 Fixed in branch 2.0.4, commit dcd8a890d3 fix #123146: window title changes after save score Reply System Message • Sep 17, 2016 - 10:05 Severity ⇒ Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Jojo-Schmitz • Sep 1, 2016 - 16:04 Severity ⇒ Interesting, while I found where the title gets set to "MuseScore: <filename>" (2 places in mscore/file.cpp, line 426 and 1799), and could fix it there, I don't see where it gets set to "MuseScore 2: <filename>". Reply
Jojo-Schmitz • Sep 1, 2016 - 16:18 Severity ⇒ Status (old) active ⇒ patch (code needs review) Ah, found it, mscore/musecore.cpp, lines 1756 and 1759. (@shoggle: yes, our posts crossed) See https://github.com/musescore/MuseScore/pull/2806, which should change file.cpp's title to match that of musescore cpp, i.e. "MuseScore 2: ..." Reply
Git Message • Sep 3, 2016 - 09:58 Severity ⇒ Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit 1e3831860e fix #123146: window title changes after save score Reply
Git Message • Sep 3, 2016 - 09:58 Fixed in branch master, commit 755cd05026 Merge pull request #2806 from Jojo-Schmitz/title fix #123146: window title changes after save score Reply
Git Message • Sep 3, 2016 - 10:03 Fixed in branch 2.0.4, commit dcd8a890d3 fix #123146: window title changes after save score Reply
System Message • Sep 17, 2016 - 10:05 Severity ⇒ Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
Interesting, while I found where the title gets set to "MuseScore: <filename>" (2 places in mscore/file.cpp, line 426 and 1799), and could fix it there, I don't see where it gets set to "MuseScore 2: <filename>".
@Jojo, here?
Ah, found it, mscore/musecore.cpp, lines 1756 and 1759.
(@shoggle: yes, our posts crossed)
See https://github.com/musescore/MuseScore/pull/2806, which should change file.cpp's title to match that of musescore cpp, i.e. "MuseScore 2: ..."
Fixed in branch master, commit 1e3831860e
fix #123146: window title changes after save score
Fixed in branch master, commit 755cd05026
Merge pull request #2806 from Jojo-Schmitz/title
fix #123146: window title changes after save score
Fixed in branch 2.0.4, commit dcd8a890d3
fix #123146: window title changes after save score
Automatically closed -- issue fixed for 2 weeks with no activity.