Crashing on lyric entry

• Jan 20, 2019 - 21:10
Reported version
3.0
Priority
P1 - High
Type
Performance
Frequency
Many
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
Tags

Enter lyrics in measure 31

Every time I enter lyrics in that measure, it crashes.

Attachment Size
Keep_The_Customer_Satisfied.mscz 41.16 KB

Comments

Status active needs info

I wasn't able to reproduce at first by entering a lyric on the first note, but as I continued, it crashed upon hitting Space after entering a lyric for the fourth note. Somehow in TextBase::endEdit() while trying to process the undo stack, we come upon a totally bogus "Add" command.

Status active PR created

In current master (but, surprisingly, not in 3.0.5) the crash can be reliably reproduced (at least for me) by going to measure 37 and entering any lyrics syllable at its first note (the crash itself happens always when I press Esc to end editing the syllable).

I created a pull request that should fix the crash, see https://github.com/musescore/MuseScore/pull/4921.

Status PR created fixed

Fixed in branch master, commit e5d8d86d7d

_fix #282333: fix a crash on adding lyrics on certain scores

Also fixes:
fix #282238, #280014: removing lyrics syllable by erasing its text
was not undoable properly_

Fix version
3.1.0