Duplicated note events in test files

• Apr 18, 2019 - 09:44
Reported version
3.x-dev
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project

Thanks to mirabilos for the report.

Quote:

you added tons of lines to e.g. mtest/libmscore/midi/testTieTrill-ref.txt
(all the reference files) in there, but why is the same event generated
four(!) times at the same MIDI time?

Example:

@@ -1,4 +1,8 @@
+Tick = 0 Type = 176 Pitch = 2 Velocity = 80 Channel = 0
Tick = 0 Type = 144 Pitch = 74 Velocity = 80 Channel = 0
+Tick = 0 Type = 176 Pitch = 2 Velocity = 80 Channel = 0
+Tick = 0 Type = 176 Pitch = 2 Velocity = 80 Channel = 0
+Tick = 0 Type = 176 Pitch = 2 Velocity = 80 Channel = 0
Tick = 0 Type = 3 Pitch = 0 Velocity = 127 Channel = 0
Tick = 55 Type = 144 Pitch = 74 Velocity = 0 Channel = 0
Tick = 60 Type = 144 Pitch = 72 Velocity = 80 Channel = 0
@@ -16,6 +20,10 @@ Tick = 415 Type = 144 Pitch = 74 Velocity = 0 Channel =
Tick = 420 Type = 144 Pitch = 72 Velocity = 80 Channel = 0
Tick = 475 Type = 144 Pitch = 72 Velocity = 0 Channel = 0
Tick = 480 Type = 144 Pitch = 74 Velocity = 80 Channel = 0
+Tick = 480 Type = 176 Pitch = 2 Velocity = 80 Channel = 0
+Tick = 480 Type = 176 Pitch = 2 Velocity = 80 Channel = 0
+Tick = 480 Type = 176 Pitch = 2 Velocity = 80 Channel = 0
+Tick = 480 Type = 176 Pitch = 2 Velocity = 80 Channel = 0
Tick = 480 Type = 4 Pitch = 0 Velocity = 80 Channel = 0
Tick = 535 Type = 144 Pitch = 74 Velocity = 0 Channel = 0
Tick = 540 Type = 144 Pitch = 72 Velocity = 80 Channel = 0

Both times, it is added four times. Is that not redundant?
Or is the output incomplete and the control carries extra info?


The reason this happens is because events are added for every voice. Evidently this is leading to the duplication of the initial note events for chord rests with a static velocity.

I'm working on a fix for this.


Comments

Fix version
3.1.0