"Show courtesy" checkbox in clef Inspector does not work
Well, it works if you have the courtesy clef itself selected, but not with the main clef. Technically, I know the apparent courtesy is the main clef, but anyhow - I mean it doesn't work the way people expect, where you select the clef at the start of the system then toggle the option in Inspector.
I broke this in the lamest possible way: the code in the Inspector responsible for sorting out which clef is which does this only for the show courtesy option, which it checks for by testing if "idx == 6". When I added a new field for autoplace min distance, that idx became 7. Incredibly, that code worked for 6 years. In all fairness, I don't think the current property system that makes this kind of thing rather easier to check now existed then.
I will submit a PR.
Comments
So relates to #289565: [Epic] 3.1-RC Regressions that must be fixed
https://github.com/musescore/MuseScore/pull/5065
Fixed in branch master, commit d8d191c030
fix #289651: show courtesy checkbox not working in clef inspector
Fixed in branch master, commit 9514436791
_Merge pull request #5065 from MarcSabatella/289651-clef-inspector
fix #289651: show courtesy checkbox not working in clef inspector_
Automatically closed -- issue fixed for 2 weeks with no activity.