UNDO does not restore a deleted frame

• Aug 24, 2019 - 17:21
Reported version
3.2
Priority
P1 - High
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project

MS 3.2.3.

Open any score with a title frame. delete the title frame, then UNDO. Nothing happens.


Comments

Title Title Frame: deleting frame cannot be undone UNDO does not restore a deleted frame

In fact, this bug applies to all frames.

Priority P1 - High

I thought all similar issues were resolved already :(
#283545: Crash on undoing removal horizontal frame
#285888: Crash on removing a horizontal frame twice

Actually here something strange happens. If after opening a score, deleting a frame and undoing it start a note input and enter some note, the frame appears back. Still if I enter some notes first, delete a frame and start to undo all those actions, then the frame seems to appear but after a wrong number of undo commands.

Anyway, yes, that should be fixed.

Status PR created fixed

Fixed in branch master, commit 3f40a56dd9

_fix #293707: undo doesn't restore deleted frame immediately

Why do these changes fix this particular issue?

After adding any other element, we setLayout at the element's
location. However, for boxes, there is an early return, and this step is
missed, meaning the box won't appear until a relevant measure is layed out.
This fix adds the missing setLayout._

Fix version
3.3.0