Ditto. Somehow we all figured out it works the second time, and users haven't complained about this (much / at all?), but definitely worth fixing, if for no reason other than it might also be indicative of some larger problem.
Actually it's not "the second time", from 4/4 to alla breve is always wrong, but 2/2 to allve breve is not, so it makes us feel like it works "the second time" but technically it doesn't.
4/4 and alla breve have different _sig value, so setSig() is called, but if it's called after _timeSigType is changed, setSig() will make the type NORMAL again, because if it's called by setProperty(), there isn't a TimeSigType parameter available (making it available will cause further issues), so setSig() uses the default NORMAL as the type, thus the new type is overwritten.
If setSig() is called before _timeSigType is changed, all will be fine._
Comments
Confirmed, seen that too myself, just hadn't yet come around to report it
Ditto. Somehow we all figured out it works the second time, and users haven't complained about this (much / at all?), but definitely worth fixing, if for no reason other than it might also be indicative of some larger problem.
In reply to Ditto. Somehow we all… by Marc Sabatella
Actually it's not "the second time", from 4/4 to alla breve is always wrong, but 2/2 to allve breve is not, so it makes us feel like it works "the second time" but technically it doesn't.
I noticed and ignored it also, so that makes this a Many frequency.
See https://github.com/musescore/MuseScore/pull/5491.
Fixed in branch master, commit 72c6b76708
_fix #297477: apply alla breve to 4/4 changes to 2/2 instead
Resolves: https://musescore.org/en/node/297477.
4/4 and alla breve have different
_sig
value, sosetSig()
is called, but if it's called after_timeSigType
is changed,setSig()
will make the typeNORMAL
again, because if it's called bysetProperty()
, there isn't aTimeSigType
parameter available (making it available will cause further issues), sosetSig()
uses the defaultNORMAL
as the type, thus the new type is overwritten.If
setSig()
is called before_timeSigType
is changed, all will be fine._Fixed in branch master, commit 8a789db0aa
_Merge pull request #5491 from Howard-C/4-4-to-alla-breve
fix #297477: apply alla breve to 4/4 changes to 2/2 instead_
Automatically closed -- issue fixed for 2 weeks with no activity.