Apply alla breve to 4/4 changes to 2/2 instead

• Nov 22, 2019 - 07:53
Reported version
3.3
Type
Functional
Frequency
Many
Severity
S4 - Minor
Reproducibility
Always
Status
fixed
Regression
Yes
Workaround
Yes
Project

It becomes alla breve the second time, when it's applied to 2/2.
Same for applying four-four to 2/2.


Comments

Ditto. Somehow we all figured out it works the second time, and users haven't complained about this (much / at all?), but definitely worth fixing, if for no reason other than it might also be indicative of some larger problem.

Status PR created fixed

Fixed in branch master, commit 72c6b76708

_fix #297477: apply alla breve to 4/4 changes to 2/2 instead

Resolves: https://musescore.org/en/node/297477.

4/4 and alla breve have different _sig value, so setSig() is called, but if it's called after _timeSigType is changed, setSig() will make the type NORMAL again, because if it's called by setProperty(), there isn't a TimeSigType parameter available (making it available will cause further issues), so setSig() uses the default NORMAL as the type, thus the new type is overwritten.

If setSig() is called before _timeSigType is changed, all will be fine._

Fix version
3.3.3