Key signatures are lost 2.X->3.0
Tested with self built MuseScore on OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (32-bit): 3.0.0, revision: 44304ca
- Open attached score
Result: systems don't have key signatures until measure 57, where key signatures are changed.
Attachment | Size |
---|---|
2510026.mscz | 93.71 KB |
Comments
relates to #275344: [EPIC] Displaying elements, position and layout when opening 2.X scores in 3.0
This is triggered by the E-flat Tuba part being written in the key of C. The code in Measure::addSystemHeader() that disables KeySig segments for key-of-C key signatures does not take into account the fact that other parts may not be written in the same key. It does, however, look at the KeySigs in the other staves, and if it finds one that is not generated, then it will not disable the segment. It could at the same time check whether the KeySig in the other staff indicates a key of C, and if it does not, then it will know to not disable the segment.
See https://github.com/musescore/MuseScore/pull/3890.
Fixed in branch master, commit 8b03a09a8d
fix #275369: Key signatures are lost 2.X->3.0
Fixed in branch master, commit bc2013ff9d
Merge pull request #3890 from mattmcclinch/275369-keysig
fix #275369: Key signatures are lost 2.X->3.0
Unfortunately, this change in the code causes errors when changing to the key of C. To see what I mean:
Result: Subsequent systems show the key signature from step 2.
I will try to come up with a solution to the original issue that does not introduce new errors. In the meantime, this code change should probably be reverted.
In reply to Unfortunately, this change… by mattmcclinch
If it is a matter of few days, it is ok, since 3.0 is not even alpha.
See https://github.com/musescore/MuseScore/pull/3911. I think I got it right this time. But of course, that's what I thought last time :)
Fixed in branch master, commit af0a6c71c7
fix #275369: Key signatures are lost 2.X->3.0
Fixed in branch master, commit 7f19224f30
Merge pull request #3911 from mattmcclinch/275369-keysig
fix #275369: Key signatures are lost 2.X->3.0
Automatically closed -- issue fixed for 2 weeks with no activity.