Select/More for rests is broken

• Nov 7, 2018 - 07:27
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project

OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.0.0, revision: 3fdfab3

1) Load this test file: rests selection.mscz
(With Ctrl + A, you can see the rests in different voices)

2) Right-click on a rest -> Select -> More

First observation: the "same subtype" box, for rest so, is greyed

And the result is: all selection fails by ticking, "Same staff", "Same voice", "Same system", "In selection", etc.

An exception: "Same duration" works.


Comments

Status PR created fixed

Fixed in branch master, commit 8a9d2fa050

fix #277912: select/more for rests broken

With this fix, if duration is not checked, then the value will be set to - 1 (an impossible duration value). When matching rests, if duration is -1 then duration as a term for matching is skipped and ignored.

In reply to by cadiz1

Hmm - no range selection involved for me.

  1. Create a new score with 1 measure
  2. Add 4 quarter rests
  3. Right click one of them and Select > All Similar Elements. This is from the menu. Not the Select More.. dialog.

This selects all four rests for you?

Oups, this is the version I got pointed to by the automatic update some minutes ago!? But at first I checked with a current self build.
Pls standby, will recheck with revision: 6ba431b

Sorry, its me again. I asked myself why it does work in 6ba431b but not in my current self build.

To get it work in the self build, I have to add
pattern.durationTicks = -1;
in score.cpp line 3112 (Score::selectSimilar(..)) and Score::selectSimilarInRange

So is it just incidence or because of different optimization settings? Anyway, in my opinion this line should be added.